Commit 3ac967ba authored by wanghailiangx's avatar wanghailiangx Committed by Tomasz Zawadzki
Browse files

bdev_iscsi: remove support for deprecated RPC names 



These were deprecated in 2019, it's time to remove
support for them now.

Change-Id: I25aea510648a55d751db3740b36fb9924d1f52ed
Signed-off-by: default avatarwanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12747


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 4d9a00d7

module/bdev/iscsi/bdev_iscsi_rpc.c

+0 −2
Original line number Diff line number Diff line
@@ -102,7 +102,6 @@ cleanup: 
	free_rpc_bdev_iscsi_create(&req);

}

SPDK_RPC_REGISTER("bdev_iscsi_create", rpc_bdev_iscsi_create, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_iscsi_create, construct_iscsi_bdev)



struct rpc_delete_iscsi {

	char *name;
@@ -150,4 +149,3 @@ cleanup: 
	free_rpc_delete_iscsi(&req);

}

SPDK_RPC_REGISTER("bdev_iscsi_delete", rpc_bdev_iscsi_delete, SPDK_RPC_RUNTIME)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_iscsi_delete, delete_iscsi_bdev)

python/spdk/rpc/bdev.py

+0 −2
Original line number Diff line number Diff line
@@ -1107,7 +1107,6 @@ def bdev_error_delete(client, name): 
    return client.call('bdev_error_delete', params)





@deprecated_alias('construct_iscsi_bdev')

def bdev_iscsi_create(client, name, url, initiator_iqn):

    """Construct an iSCSI block device.
@@ -1127,7 +1126,6 @@ def bdev_iscsi_create(client, name, url, initiator_iqn): 
    return client.call('bdev_iscsi_create', params)





@deprecated_alias('delete_iscsi_bdev')

def bdev_iscsi_delete(client, name):

    """Remove iSCSI bdev from the system.

scripts/rpc.py

+2 −3
Original line number Diff line number Diff line
@@ -1006,7 +1006,7 @@ if __name__ == "__main__": 
                                              url=args.url,

                                              initiator_iqn=args.initiator_iqn))



    p = subparsers.add_parser('bdev_iscsi_create', aliases=['construct_iscsi_bdev'],

    p = subparsers.add_parser('bdev_iscsi_create',

                              help='Add bdev with iSCSI initiator backend')

    p.add_argument('-b', '--name', help="Name of the bdev", required=True)

    p.add_argument('-i', '--initiator-iqn', help="Initiator IQN", required=True)
@@ -1017,8 +1017,7 @@ if __name__ == "__main__": 
        rpc.bdev.bdev_iscsi_delete(args.client,

                                   name=args.name)



    p = subparsers.add_parser('bdev_iscsi_delete', aliases=['delete_iscsi_bdev'],

                              help='Delete an iSCSI bdev')

    p = subparsers.add_parser('bdev_iscsi_delete', help='Delete an iSCSI bdev')

    p.add_argument('name', help='iSCSI bdev name')

    p.set_defaults(func=bdev_iscsi_delete)