Commit 3a65c872 authored by Hailiang Wang's avatar Hailiang Wang Committed by Ben Walker
Browse files

lib/nvme: fix a warning of spdk_pci_addr->domain 



Compilation Warning on fedora30.
In file included from nvme_ut.c:42:
/home/vagrant/spdk_repo/spdk/test/common/lib/test_env.c:517:17:
warning: The left operand of '>' is a garbage value
        if (a1->domain > a2->domain) {
            ~~~~~~~~~~ ^
This is related to issue #822.

Change-Id: I2b61e821130b89af04db3c475e81d2e91a380a90
Signed-off-by: default avatarHailiang Wang <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459923


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 6e4f5e0b

lib/nvme/nvme.c

+2 −2
Original line number Diff line number Diff line
@@ -961,8 +961,8 @@ spdk_nvme_transport_id_compare(const struct spdk_nvme_transport_id *trid1, 
	}



	if (trid1->trtype == SPDK_NVME_TRANSPORT_PCIE) {

		struct spdk_pci_addr pci_addr1;

		struct spdk_pci_addr pci_addr2;

		struct spdk_pci_addr pci_addr1 = {};

		struct spdk_pci_addr pci_addr2 = {};



		/* Normalize PCI addresses before comparing */

		if (spdk_pci_addr_parse(&pci_addr1, trid1->traddr) < 0 ||