Commit 3a5ebfb0 authored by Anil Veerabhadrappa's avatar Anil Veerabhadrappa Committed by Konrad Sztyber
Browse files

ut/fc: Cleanup transport cleanup tests 



   This change fixes the following assert in FC UT,

   transport.c:329: spdk_nvmf_transport_create: Assertion `nvmf_get_transport_ops(transport_name) && nvmf_get_transport_ops(transport_name)->create' failed.

Change-Id: I57a9c6e83f07656b207d74bbadeb82e5efb5fa32
Signed-off-by: default avatarAnil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17717


Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 665e3805

test/unit/lib/nvmf/fc.c/fc_ut.c

+0 −36
Original line number Diff line number Diff line
@@ -33,38 +33,6 @@ 
 * SPDK Stuff

 */



#ifdef SPDK_CONFIG_RDMA

const struct spdk_nvmf_transport_ops spdk_nvmf_transport_rdma = {

	.type = SPDK_NVME_TRANSPORT_RDMA,

	.opts_init = NULL,

	.create = NULL,

	.destroy = NULL,



	.listen = NULL,

	.stop_listen = NULL,

	.accept = NULL,



	.listener_discover = NULL,



	.poll_group_create = NULL,

	.poll_group_destroy = NULL,

	.poll_group_add = NULL,

	.poll_group_poll = NULL,



	.req_free = NULL,

	.req_complete = NULL,



	.qpair_fini = NULL,

	.qpair_get_peer_trid = NULL,

	.qpair_get_local_trid = NULL,

	.qpair_get_listen_trid = NULL,

};

#endif



const struct spdk_nvmf_transport_ops spdk_nvmf_transport_tcp = {

	.type = SPDK_NVME_TRANSPORT_TCP,

};



DEFINE_STUB(spdk_nvme_transport_id_compare, int,

	    (const struct spdk_nvme_transport_id *trid1,

	     const struct spdk_nvme_transport_id *trid2), 0);
@@ -291,10 +259,6 @@ create_transport_test(void) 
	poll_thread(0);



	/* create transport with bad args/options */

#ifndef SPDK_CONFIG_RDMA

	CU_ASSERT(spdk_nvmf_transport_create("RDMA", &opts) == NULL);

#endif

	CU_ASSERT(spdk_nvmf_transport_create("Bogus Transport", &opts) == NULL);

	opts.max_io_size = 1024 ^ 3;

	CU_ASSERT(spdk_nvmf_transport_create("FC", &opts) == NULL);

	opts.max_io_size = 999;