Commit 3a5abc63 authored by JinYu's avatar JinYu Committed by Darek Stojaczyk
Browse files

test/unit: Make sure the function runs correctly 



1,add a judgement to ensure spdk_blob_close() runs correctly.
2,make sure the command has been completed before _spdk_bs_free()
which would avoid heap-use-after-free.

Change-Id: I698521d8d4d8e1d8a7374665d27d6eec6d0b85f5
Signed-off-by: default avatarJinYu <jin.yu@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449517


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 6a67d517

test/unit/lib/blob/blob.c/blob_ut.c

+8 −0
Original line number Diff line number Diff line
@@ -3539,6 +3539,8 @@ blob_dirty_shutdown(void) 
	free_clusters = spdk_bs_free_cluster_count(g_bs);



	spdk_blob_close(blob, blob_op_complete, NULL);

	poll_threads();

	CU_ASSERT(g_bserrno == 0);

	blob = NULL;

	g_blob = NULL;

	g_blobid = SPDK_BLOBID_INVALID;
@@ -3645,6 +3647,8 @@ blob_dirty_shutdown(void) 
	free_clusters = spdk_bs_free_cluster_count(g_bs);



	spdk_blob_close(blob, blob_op_complete, NULL);

	poll_threads();

	CU_ASSERT(g_bserrno == 0);

	blob = NULL;

	g_blob = NULL;

	g_blobid = SPDK_BLOBID_INVALID;
@@ -3749,6 +3753,7 @@ blob_dirty_shutdown(void) 


	spdk_blob_close(blob, blob_op_complete, NULL);

	poll_threads();

	CU_ASSERT(g_bserrno == 0);

	blob = NULL;

	g_blob = NULL;

	g_blobid = SPDK_BLOBID_INVALID;
@@ -3769,6 +3774,7 @@ blob_dirty_shutdown(void) 


	spdk_blob_close(blob, blob_op_complete, NULL);

	poll_threads();

	CU_ASSERT(g_bserrno == 0);

	blob = NULL;

	g_blob = NULL;

	g_blobid = SPDK_BLOBID_INVALID;
@@ -3806,6 +3812,8 @@ blob_dirty_shutdown(void) 
	CU_ASSERT(free_clusters == spdk_bs_free_cluster_count(g_bs));



	spdk_blob_close(blob, blob_op_complete, NULL);

	poll_threads();

	CU_ASSERT(g_bserrno == 0);

	blob = NULL;

	g_blob = NULL;

	g_blobid = SPDK_BLOBID_INVALID;