Commit 39c4f95b authored Mar 12, 2019 by Ziye Yang Committed by Darek Stojaczyk Mar 12, 2019

bdev: remove the unnecessary spdk_bdev_finish call.

The calling of spdk_bdev_finish is in wrong place,
the bdev subsystem recycling will be called by
_spdk_subsystem_fini_next. If we call spdk_bdev_finish
here, it will be called twice, so it is unnecessary.

And this patch will be used to address the issue
reported in:

https://review.gerrithub.io/#/c/spdk/spdk/+/447613/



Change-Id: I03dff8b84bd0d7b49675ce8300b3da623963e140
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/447731


Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent 267f09de

lib/bdev/bdev.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -874,17 +874,10 @@ spdk_bdev_modules_init(void)
		return 0;
		}


		static void
		spdk_bdev_init_failed_complete(void *cb_arg)
		{
		spdk_bdev_init_complete(-1);
		}

		static void
		spdk_bdev_init_failed(void *cb_arg)
		{
		spdk_bdev_finish(spdk_bdev_init_failed_complete, NULL);
		spdk_bdev_init_complete(-1);
		}

		void

Admin message