Commit 39068b6b authored Feb 11, 2020 by Shuhei Matsumoto Committed by Tomasz Zawadzki Feb 17, 2020

lib/iscsi: Fix a scan-build warning



1 warning generated.
  LIB libspdk_nvmf.a
iscsi_subsystem.c:1285:25: warning: Result of 'calloc' is converted to a pointer
of type 'struct spdk_iscsi_sess *', which is incompatible with sizeof operand type 'void *'
        g_spdk_iscsi.session = calloc(1, sizeof(void *) * g_spdk_iscsi.MaxSessions);
                               ^~~~~~    ~~~~~~~~~~~~~
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>

Change-Id: Ieb8dcac8ec172405c5ca97a4867582ff9bfaa569
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/827


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

parent aefe3fe2

lib/iscsi/iscsi_subsystem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1322,7 +1322,7 @@ iscsi_parse_globals(void)
		return rc;
		}

		g_spdk_iscsi.session = calloc(1, sizeof(void ) g_spdk_iscsi.MaxSessions);
		g_spdk_iscsi.session = calloc(1, sizeof(struct spdk_iscsi_sess ) g_spdk_iscsi.MaxSessions);
		if (!g_spdk_iscsi.session) {
		SPDK_ERRLOG("calloc() failed for session array\n");
		return -1;