Commit 36f8f8da authored by Richael Zhuang's avatar Richael Zhuang Committed by Tomasz Zawadzki
Browse files

bdev: remove bdev parameter 



Remove bdev parameter from spdk_bdev_channel_get_histogram since
it's not used.

Change-Id: I89f0b142cc6f80ecf39811976995f738e4cfecdb
Signed-off-by: default avatarRichael Zhuang <richael.zhuang@arm.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15837


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarMike Gerdts <mgerdts@nvidia.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
parent 86431df1

include/spdk/bdev.h

+2 −3
Original line number Diff line number Diff line
@@ -1951,13 +1951,12 @@ void spdk_bdev_histogram_get(struct spdk_bdev *bdev, struct spdk_histogram_data 
 * is only valid during the execution of cb_fn. Referencing the histogram after cb_fn

 * returns is not supported and yields undetermined behavior.

 *

 * \param bdev Block device.

 * \param ch IO channel of bdev.

 * \param cb_fn Callback function to process the histogram of the channel.

 * \param cb_arg Argument to pass to cb_fn.

 */

void spdk_bdev_channel_get_histogram(struct spdk_bdev *bdev, struct spdk_io_channel *ch,

				     spdk_bdev_histogram_data_cb cb_fn, void *cb_arg);

void spdk_bdev_channel_get_histogram(struct spdk_io_channel *ch, spdk_bdev_histogram_data_cb cb_fn,

				     void *cb_arg);



/**

 * Retrieves media events.  Can only be called from the context of

lib/bdev/bdev.c

+2 −2
Original line number Diff line number Diff line
@@ -7880,8 +7880,8 @@ spdk_bdev_histogram_get(struct spdk_bdev *bdev, struct spdk_histogram_data *hist 
}



void

spdk_bdev_channel_get_histogram(struct spdk_bdev *bdev, struct spdk_io_channel *ch,

				spdk_bdev_histogram_data_cb cb_fn, void *cb_arg)

spdk_bdev_channel_get_histogram(struct spdk_io_channel *ch, spdk_bdev_histogram_data_cb cb_fn,

				void *cb_arg)

{

	struct spdk_bdev_channel *bdev_ch = __io_ch_to_bdev_ch(ch);

	int status = 0;

test/unit/lib/bdev/bdev.c/bdev_ut.c

+2 −2
Original line number Diff line number Diff line
@@ -3506,7 +3506,7 @@ bdev_histograms(void) 
	CU_ASSERT(g_count == 2);



	g_count = 0;

	spdk_bdev_channel_get_histogram(bdev, ch, histogram_channel_data_cb, histogram_io_count);

	spdk_bdev_channel_get_histogram(ch, histogram_channel_data_cb, histogram_io_count);

	CU_ASSERT(g_status == 0);

	CU_ASSERT(g_count == 2);
@@ -3521,7 +3521,7 @@ bdev_histograms(void) 
	poll_threads();

	CU_ASSERT(g_status == -EFAULT);



	spdk_bdev_channel_get_histogram(bdev, ch, histogram_channel_data_cb, NULL);

	spdk_bdev_channel_get_histogram(ch, histogram_channel_data_cb, NULL);

	CU_ASSERT(g_status == -EFAULT);



	spdk_histogram_data_free(histogram);