Commit 36304737 authored by Zhiqiang Liu's avatar Zhiqiang Liu Committed by Tomasz Zawadzki
Browse files

ioat: fix potential double free problem in ioat_channel_start() 



In ioat_channel_start(), if spdk_vtophys(ioat->comp_update) returns
SPDK_VTOPHYS_ERROR, spdk_free is called to free ioat->comp_update,
and ioat->comp_update is not set to NULL. However, the caller
ioat_attach() will also call ioat_channel_destruct() to free
ioat->comp_update, then double-free problem occurs.

Here, we will not free ioat->comp_update in ioat_channel_start(),
ioat_channel_destruct() will do that.

Signed-off-by: default avatarZhiqiang Liu <liuzhiqiang26@huawei.com>
Change-Id: I3be19a3feec5c2188051ee67820bfd1e61de9b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8300


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent f9734138

lib/ioat/ioat.c

+0 −1
Original line number Diff line number Diff line
@@ -429,7 +429,6 @@ ioat_channel_start(struct spdk_ioat_chan *ioat) 


	comp_update_bus_addr = spdk_vtophys((void *)ioat->comp_update, NULL);

	if (comp_update_bus_addr == SPDK_VTOPHYS_ERROR) {

		spdk_free((void *)ioat->comp_update);

		return -1;

	}