Commit 36287957 authored by Ben Walker's avatar Ben Walker Committed by Darek Stojaczyk
Browse files

event: Remove arg2 from spdk_app_start() 



We never used this anywhere, and I need to move to a model where
the start up action is a thread message instead

Change-Id: I6b21ba9afb93a3245aceca2fe24713ffd16d0933
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/446986


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 88179a65

CHANGELOG.md

+4 −0
Original line number Diff line number Diff line
@@ -2,6 +2,10 @@ 


## v19.04: (Upcoming Release)



### thread



spdk_app_start() now only accepts a single context argument.



### nvme



Added asynchronous probe support.  New APIs spdk_nvme_probe_async() and

app/iscsi_tgt/iscsi_tgt.c

+1 −1
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ main(int argc, char **argv) 
	opts.usr1_handler = spdk_sigusr1;



	/* Blocks until the application is exiting */

	rc = spdk_app_start(&opts, spdk_startup, NULL, NULL);

	rc = spdk_app_start(&opts, spdk_startup, NULL);

	if (rc) {

		SPDK_ERRLOG("Start iscsi target daemon:  spdk_app_start() retn non-zero\n");

	}

app/nvmf_tgt/nvmf_main.c

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ main(int argc, char **argv) 
	}



	/* Blocks until the application is exiting */

	rc = spdk_app_start(&opts, nvmf_tgt_started, NULL, NULL);

	rc = spdk_app_start(&opts, nvmf_tgt_started, NULL);

	spdk_app_fini();

	return rc;

}

app/spdk_tgt/spdk_tgt.c

+1 −1
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ main(int argc, char **argv) 
		return rc;

	}



	rc = spdk_app_start(&opts, spdk_tgt_started, NULL, NULL);

	rc = spdk_app_start(&opts, spdk_tgt_started, NULL);

	spdk_app_fini();



	return rc;

app/vhost/vhost.c

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ main(int argc, char *argv[]) 
	}



	/* Blocks until the application is exiting */

	rc = spdk_app_start(&opts, vhost_started, NULL, NULL);

	rc = spdk_app_start(&opts, vhost_started, NULL);



	spdk_app_fini();