Commit 35e5917e authored by Alexey Marchuk's avatar Alexey Marchuk Committed by Konrad Sztyber
Browse files

test/dma: Remove task::is_random 



That is enough to use a global variable since
all tasks are either random or not

Suggested-by: default avatarJim Harris <jim.harris@samsung.com>
Signed-off-by: default avatarAlexey Marchuk <alexeymar@nvidia.com>
Change-Id: If857f62a920266c0f6e56bb834e5b68224f928e8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24816


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 53be3bd8

test/dma/test_dma/test_dma.c

+1 −3
Original line number Diff line number Diff line
@@ -44,7 +44,6 @@ struct dma_test_task { 
	struct dma_test_task_stats stats;

	struct dma_test_task_stats last_stats;

	bool is_draining;

	bool is_random;

	struct dma_test_req *reqs;

	struct spdk_thread *thread;

	const char *bdev_name;
@@ -240,7 +239,7 @@ dma_test_get_offset_in_ios(struct dma_test_task *task) 
{

	uint64_t offset;



	if (task->is_random) {

	if (g_is_random) {

		offset = rand_r(&task->seed) % task->max_offset_in_ios;

	} else {

		offset = task->cur_io_offset++;
@@ -680,7 +679,6 @@ allocate_task(uint32_t core, const char *bdev_name) 
	task->seed = core;

	task->lcore = core;

	task->bdev_name = bdev_name;

	task->is_random = g_is_random;

	task->rw_percentage = g_rw_percentage;

	task->num_blocks_per_io = g_num_blocks_per_io;

	task->stats.min_tsc = UINT64_MAX;