Commit 35d679a7 authored Sep 22, 2023 by Michal Berger Committed by Tomasz Zawadzki Oct 13, 2023

autopackage: Move porcelain check to autobuild



autopackage.sh has no view into autobuild nor autotest infra, hence
it should not be responsible for similar verification. It was also
depending on a wonky config.mk check which was assuming SPDK had
been built prior running this script.

Remove all that and move the check to autobuild as an extra test in
build_files().

If we need to verify if autotest itself is leaving any garbage
behind, then similar functionality must be implemented directly
in the test suite.

Change-Id: If338b16779feeb2d1a7bf7bea51cba8da18ffef7
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20025


Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

parent 441ad56e

autopackage.sh

+0 −12

Original line number	Diff line number	Diff line
		@@ -10,18 +10,6 @@ source "$rootdir/test/common/autobuild_common.sh"
		MAKEFLAGS=${MAKEFLAGS:--j16}
		cd $rootdir

		timing_enter porcelain_check
		if [[ -e $rootdir/mk/config.mk ]]; then
		$MAKE clean
		fi

		if [ $(git status --porcelain --ignore-submodules \| wc -l) -ne 0 ]; then
		echo make clean left the following files:
		git status --porcelain --ignore-submodules
		exit 1
		fi
		timing_exit porcelain_check

		if [[ $SPDK_TEST_RELEASE_BUILD -eq 1 ]]; then
		build_packaging
		$MAKE clean

test/common/autobuild_common.sh

+2 −0

Original line number	Diff line number	Diff line
		@@ -375,6 +375,8 @@ build_files() {
		run_test "autobuild_header_dependency_check" header_dependency_check
		run_test "autobuild_make_install" test_make_install
		run_test "autobuild_make_uninstall" test_make_uninstall
		$MAKE clean
		run_test "autobuild_generated_files_check_post_clean" porcelain_check
		}

		build_doc() {