Commit 35a9ddb5 authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Jim Harris
Browse files

test: restore rpc_py to point to rpc.py instead of rpc_cmd 



rpc_cmd function does not tolerate piping arguments into it,
so code execution skips the parts responsible for generating
a return code. The code is equal to nothing or "", which then
is compared with a value, ultimately erroring out the whole test.
To avoid these problems restore rpc_py varible declaration
in multiconnection.sh and ext4test.sh scripts.

Additionally added a comment in compress.sh to match ext4test.sh
and multiconnection.sh.

Change-Id: I4fb5f737d4e97d602f522b810363bc0d4522bf0d
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14356


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDong Yi <dongx.yi@intel.com>
Reviewed-by: default avatarPawel Piatek <pawelx.piatek@intel.com>
Reviewed-by: default avatarKamil Godzwon <kamilx.godzwon@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent b50af42b

test/compress/compress.sh

+3 −0
Original line number Diff line number Diff line
@@ -8,6 +8,9 @@ plugindir=$rootdir/examples/bdev/fio_plugin 
source "$rootdir/scripts/common.sh"

source "$rootdir/test/common/autotest_common.sh"

source "$rootdir/test/nvmf/common.sh"



# Declare rpc_py here, because its default value points to rpc_cmd function,

# which does not tolerate piping arguments into it.

rpc_py="$rootdir/scripts/rpc.py"



function error_cleanup() {

test/iscsi_tgt/ext4test/ext4test.sh

+3 −0
Original line number Diff line number Diff line
@@ -7,6 +7,9 @@ source $rootdir/test/iscsi_tgt/common.sh 


iscsitestinit



# Declare rpc_py here, because its default value points to rpc_cmd function,

# which does not tolerate piping arguments into it.

rpc_py="$rootdir/scripts/rpc.py"

node_base="iqn.2013-06.com.intel.ch.spdk"



timing_enter start_iscsi_tgt

test/iscsi_tgt/multiconnection/multiconnection.sh

+3 −0
Original line number Diff line number Diff line
@@ -7,6 +7,9 @@ source $rootdir/test/iscsi_tgt/common.sh 


iscsitestinit



# Declare rpc_py here, because its default value points to rpc_cmd function,

# which does not tolerate piping arguments into it.

rpc_py="$rootdir/scripts/rpc.py"

fio_py="$rootdir/scripts/fio-wrapper"



CONNECTION_NUMBER=30