Commit 3500d9a9 authored by Mateusz Kozlowski's avatar Mateusz Kozlowski Committed by Darek Stojaczyk
Browse files

lib/ftl: Add error log after IO failure 



Adding some extra debug information for any failing IOs.

Signed-off-by: default avatarMateusz Kozlowski <mateusz.kozlowski@intel.com>
Change-Id: If38de30bcb80d291778ad7325a33b7786d02390d
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/461588


Reviewed-by: default avatarWojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 6b92b21d

lib/ftl/ftl_io.c

+7 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ 
#include "ftl_core.h"

#include "ftl_rwb.h"

#include "ftl_band.h"

#include "ftl_debug.h"



void

ftl_io_inc_req(struct ftl_io *io)
@@ -488,12 +489,18 @@ ftl_io_alloc_child(struct ftl_io *parent) 
void

ftl_io_process_error(struct ftl_io *io, const struct spdk_nvme_cpl *status)

{

	char ppa_buf[128];



	/* TODO: add error handling for specifc cases */

	if (status->status.sct == SPDK_NVME_SCT_MEDIA_ERROR &&

	    status->status.sc == SPDK_OCSSD_SC_READ_HIGH_ECC) {

		return;

	}



	SPDK_ERRLOG("Status code type 0x%x, status code 0x%x for IO type %u @ppa: %s, lba 0x%lx, cnt %lu\n",

		    status->status.sct, status->status.sc, io->type, ftl_ppa2str(io->ppa, ppa_buf, sizeof(ppa_buf)),

		    ftl_io_get_lba(io, 0), io->lbk_cnt);



	io->status = -EIO;

}