Commit 334aeff9 authored by Maciej Szwed's avatar Maciej Szwed Committed by Tomasz Zawadzki
Browse files

nvme: Don't ring a doorbell for first of fused commands 



This patch adds first_fused_submitted field in spdk_nvme_qpair
structure which is used for postponing ringing a doorbell for
fused commands.

Signed-off-by: default avatarMaciej Szwed <maciej.szwed@intel.com>
Change-Id: Ibfc43931891ebaadbafa4895c05af9f228440210

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477024


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
parent 1c5d9803

lib/nvme/nvme_internal.h

+2 −0
Original line number Diff line number Diff line
@@ -378,6 +378,8 @@ struct spdk_nvme_qpair { 
	 */

	uint8_t				no_deletion_notification_needed: 1;



	uint8_t				first_fused_submitted: 1;



	enum spdk_nvme_transport_type	trtype;



	STAILQ_HEAD(, nvme_request)	free_req;

lib/nvme/nvme_pcie.c

+11 −0
Original line number Diff line number Diff line
@@ -1244,6 +1244,12 @@ nvme_pcie_qpair_ring_sq_doorbell(struct spdk_nvme_qpair *qpair) 
	struct nvme_pcie_ctrlr	*pctrlr = nvme_pcie_ctrlr(qpair->ctrlr);

	bool need_mmio = true;



	if (qpair->first_fused_submitted) {

		/* This is first cmd of two fused commands - don't ring doorbell */

		qpair->first_fused_submitted = 0;

		return;

	}



	if (spdk_unlikely(pqpair->flags.has_shadow_doorbell)) {

		need_mmio = nvme_pcie_qpair_update_mmio_required(qpair,

				pqpair->sq_tail,
@@ -1289,6 +1295,11 @@ nvme_pcie_qpair_submit_tracker(struct spdk_nvme_qpair *qpair, struct nvme_tracke 
	req = tr->req;

	assert(req != NULL);



	if (req->cmd.fuse == SPDK_NVME_IO_FLAGS_FUSE_FIRST) {

		/* This is first cmd of two fused commands - don't ring doorbell */

		qpair->first_fused_submitted = 1;

	}



	/* Copy the command from the tracker to the submission queue. */

	nvme_pcie_copy_command(&pqpair->cmd[pqpair->sq_tail], &req->cmd);