Commit 324ebbfc authored Oct 06, 2020 by Tomasz Zawadzki

log: remove SPDK_ERRLOGDUMP



This macro was used in only single place and served no real
purpose.

spdk_log_dump() is more commonly used directly, so use it.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Idea720cdee767c7c6cdc30db10003ef42b88c4a3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4540


Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Mellanox Build Bot

parent 7b5d9b06

include/spdk_internal/log.h

+0 −7

Original line number	Diff line number	Diff line
		@@ -41,11 +41,4 @@

		#include "spdk/log.h"

		#define SPDK_ERRLOGDUMP(LABEL, BUF, LEN) \
		do { \
		if ((LEN)) { \
		spdk_log_dump(stderr, (LABEL), (BUF), (LEN)); \
		} \
		} while (0)

		#endif /* SPDK_INTERNAL_LOG_H */

lib/iscsi/iscsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4322,7 +4322,7 @@ init_login_reject_response(struct spdk_iscsi_pdu pdu, struct spdk_iscsi_pdu rs
		static void
		iscsi_pdu_dump(struct spdk_iscsi_pdu *pdu)
		{
		SPDK_ERRLOGDUMP("PDU", (uint8_t *)&pdu->bhs, ISCSI_BHS_LEN);
		spdk_log_dump(stderr, "PDU", (uint8_t *)&pdu->bhs, ISCSI_BHS_LEN);
		}

		/* This function is used to refree the pdu when it is acknowledged */