Commit 3181857b authored by Ed rodriguez's avatar Ed rodriguez Committed by Ben Walker
Browse files

util: Remove usage of abort from library code 



Change-Id: Ie03b29907f152dc2d0072b84b32a1f5d58818c74
Signed-off-by: default avatarEd rodriguez <edwinr@netapp.com>
Signed-off-by: default avatarJohn Meneghini <johnm@netapp.com>
Reviewed-on: https://review.gerrithub.io/419285


Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent a28a5c8f

lib/log/log_flags.c

+4 −2
Original line number Diff line number Diff line
@@ -87,12 +87,14 @@ spdk_log_register_trace_flag(const char *name, struct spdk_trace_flag *flag) 


	if (name == NULL || flag == NULL) {

		SPDK_ERRLOG("missing spdk_trace_flag parameters\n");

		abort();

		assert(false);

		return;

	}



	if (get_trace_flag(name)) {

		SPDK_ERRLOG("duplicate spdk_trace_flag '%s'\n", name);

		abort();

		assert(false);

		return;

	}



	TAILQ_FOREACH(iter, &g_trace_flags, tailq) {

lib/thread/thread.c

+6 −3
Original line number Diff line number Diff line
@@ -223,18 +223,21 @@ spdk_poller_register(spdk_poller_fn fn, 


	thread = spdk_get_thread();

	if (!thread) {

		abort();

		assert(false);

		return NULL;

	}



	if (!thread->start_poller_fn || !thread->stop_poller_fn) {

		SPDK_ERRLOG("No related functions to start requested poller\n");

		abort();

		assert(false);

		return NULL;

	}



	poller = thread->start_poller_fn(thread->thread_ctx, fn, arg, period_microseconds);

	if (!poller) {

		SPDK_ERRLOG("Unable to start requested poller\n");

		abort();

		assert(false);

		return NULL;

	}



	return poller;