Commit 3067ecaa authored by Mao Jiang's avatar Mao Jiang Committed by Tomasz Zawadzki
Browse files

nvme/ctrlr: fix namespaces indexed overflow risk 



Change-Id: Ied1de194621a02f6eeaafc23ce5ff467760a71aa
Signed-off-by: default avatarMao Jiang <maox.jiang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7772


Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent b940247b

lib/nvme/nvme_ctrlr.c

+16 −1
Original line number Diff line number Diff line
@@ -3771,6 +3771,10 @@ spdk_nvme_ctrlr_attach_ns(struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid, 
	int					res;

	struct spdk_nvme_ns			*ns;



	if (nsid == 0) {

		return -EINVAL;

	}



	status = calloc(1, sizeof(*status));

	if (!status) {

		NVME_CTRLR_ERRLOG(ctrlr, "Failed to allocate status tracker\n");
@@ -3809,6 +3813,10 @@ spdk_nvme_ctrlr_detach_ns(struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid, 
	int					res;

	struct spdk_nvme_ns			*ns;



	if (nsid == 0) {

		return -EINVAL;

	}



	status = calloc(1, sizeof(*status));

	if (!status) {

		NVME_CTRLR_ERRLOG(ctrlr, "Failed to allocate status tracker\n");
@@ -3870,8 +3878,11 @@ spdk_nvme_ctrlr_create_ns(struct spdk_nvme_ctrlr *ctrlr, struct spdk_nvme_ns_dat 
	}



	nsid = status->cpl.cdw0;

	ns = &ctrlr->ns[nsid - 1];

	free(status);



	assert(nsid > 0);



	ns = &ctrlr->ns[nsid - 1];

	/* Inactive NS */

	res = nvme_ns_construct(ns, nsid, ctrlr);

	if (res) {
@@ -3889,6 +3900,10 @@ spdk_nvme_ctrlr_delete_ns(struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid) 
	int					res;

	struct spdk_nvme_ns			*ns;



	if (nsid == 0) {

		return -EINVAL;

	}



	status = calloc(1, sizeof(*status));

	if (!status) {

		NVME_CTRLR_ERRLOG(ctrlr, "Failed to allocate status tracker\n");