Commit 304fde15 authored by Ziye Yang's avatar Ziye Yang Committed by Tomasz Zawadzki
Browse files

nvmf/tcp: remove nvmf_tcp_pdu_cmd_complete 



This function can be removed if we change the parameter type
in nvmf_tcp_request_free.

Change-Id: I4dbf0e7fa79c8c0115d7bcae99cb241aec367f1a
Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5702


Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent f420b9ef

lib/nvmf/tcp.c

+3 −9
Original line number Diff line number Diff line
@@ -368,9 +368,10 @@ nvmf_tcp_req_get(struct spdk_nvmf_tcp_qpair *tqpair) 
}



static void

nvmf_tcp_request_free(struct spdk_nvmf_tcp_req *tcp_req)

nvmf_tcp_request_free(void *cb_arg)

{

	struct spdk_nvmf_tcp_transport *ttransport;

	struct spdk_nvmf_tcp_req *tcp_req = cb_arg;



	assert(tcp_req != NULL);
@@ -1373,13 +1374,6 @@ err: 
	nvmf_tcp_send_c2h_term_req(tqpair, pdu, fes, error_offset);

}



static void

nvmf_tcp_pdu_cmd_complete(void *cb_arg)

{

	struct spdk_nvmf_tcp_req *tcp_req = cb_arg;

	nvmf_tcp_request_free(tcp_req);

}



static void

nvmf_tcp_send_capsule_resp_pdu(struct spdk_nvmf_tcp_req *tcp_req,

			       struct spdk_nvmf_tcp_qpair *tqpair)
@@ -1401,7 +1395,7 @@ nvmf_tcp_send_capsule_resp_pdu(struct spdk_nvmf_tcp_req *tcp_req, 
		capsule_resp->common.plen += SPDK_NVME_TCP_DIGEST_LEN;

	}



	nvmf_tcp_qpair_write_pdu(tqpair, rsp_pdu, nvmf_tcp_pdu_cmd_complete, tcp_req);

	nvmf_tcp_qpair_write_pdu(tqpair, rsp_pdu, nvmf_tcp_request_free, tcp_req);

}



static void