Commit 2f3147c0 authored by JinYu's avatar JinYu Committed by Darek Stojaczyk
Browse files

bdev: fix potential segmentation fault bug 



As the bdev_io maybe NULL, so put the assignment after assert(bdev_io != NULL).

Change-Id: I58d6fcf97931b2f431ad5680b87b098e0c9a5e9b
Signed-off-by: default avatarJinYu <jin.yu@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449296


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
parent db541f8e

lib/bdev/bdev.c

+3 −1
Original line number Diff line number Diff line
@@ -1194,11 +1194,13 @@ spdk_bdev_get_io(struct spdk_bdev_channel *channel) 
void

spdk_bdev_free_io(struct spdk_bdev_io *bdev_io)

{

	struct spdk_bdev_mgmt_channel *ch = bdev_io->internal.ch->shared_resource->mgmt_ch;

	struct spdk_bdev_mgmt_channel *ch;



	assert(bdev_io != NULL);

	assert(bdev_io->internal.status != SPDK_BDEV_IO_STATUS_PENDING);



	ch = bdev_io->internal.ch->shared_resource->mgmt_ch;



	if (bdev_io->internal.buf != NULL) {

		spdk_bdev_io_put_buf(bdev_io);

	}