Commit 2dbdb994 authored by Ben Walker's avatar Ben Walker Committed by Jim Harris
Browse files

test/nvme: Only test non-contiguous namespaces for NVMe 1.2 or higher 



This wasn't supported before NVMe 1.2

Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Change-Id: Ibf19cd77e522eb11c2091a9f4956f5616876986b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10097


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 52e432df

test/unit/lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c

+12 −8
Original line number Diff line number Diff line
@@ -2118,6 +2118,9 @@ test_nvme_ctrlr_test_active_ns(void) 
		nsid = spdk_nvme_ctrlr_get_first_active_ns(&ctrlr);

		CU_ASSERT(nsid == 1);



		if (minor >= 2) {

			/* For NVMe 1.2 and newer, the namespace list can have "holes" where

			 * some namespaces are not active. Test this. */

			ctrlr.active_ns_list[1] = 3;

			CU_ASSERT(spdk_nvme_ctrlr_is_active_ns(&ctrlr, 1) == true);

			CU_ASSERT(spdk_nvme_ctrlr_is_active_ns(&ctrlr, 2) == false);
@@ -2126,6 +2129,7 @@ test_nvme_ctrlr_test_active_ns(void) 
			CU_ASSERT(nsid == 3);

			nsid = spdk_nvme_ctrlr_get_next_active_ns(&ctrlr, nsid);

			CU_ASSERT(nsid == 0);

		}



		memset(ctrlr.active_ns_list, 0, sizeof(uint32_t) * ctrlr.num_ns);

		for (nsid = 0; nsid < ctrlr.num_ns; nsid++) {