Commit 2db4a553 authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

ublk: sort cmd_op case statements in ublk_ctrl_cmd 



Sort the case statements by the normal order in which
the commands are submitted.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I203a70045cd48d30d1229c754ddb57e7e31460af
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16455


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarXiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 525dcf49

lib/ublk/ublk.c

+9 −9
Original line number Diff line number Diff line
@@ -248,25 +248,25 @@ ublk_ctrl_cmd(struct spdk_ublk_dev *ublk, uint32_t cmd_op) 
	ublk->next_state_fn = NULL;



	switch (cmd_op) {

	case UBLK_CMD_START_DEV:

		cmd->data[0] = getpid();

		cmd->data[1] = 0;

		break;

	case UBLK_CMD_ADD_DEV:

		ublk->next_state_fn = ublk_set_params;

		cmd->addr = (__u64)(uintptr_t)&ublk->dev_info;

		cmd->len = sizeof(ublk->dev_info);

		break;

	case UBLK_CMD_STOP_DEV:

		break;

	case UBLK_CMD_DEL_DEV:

		ublk->next_state_fn = ublk_delete_dev;

		break;

	case UBLK_CMD_SET_PARAMS:

		ublk->next_state_fn = ublk_finish_start;

		cmd->addr = (__u64)(uintptr_t)&ublk->dev_params;

		cmd->len = sizeof(ublk->dev_params);

		break;

	case UBLK_CMD_START_DEV:

		cmd->data[0] = getpid();

		cmd->data[1] = 0;

		break;

	case UBLK_CMD_STOP_DEV:

		break;

	case UBLK_CMD_DEL_DEV:

		ublk->next_state_fn = ublk_delete_dev;

		break;

	default:

		SPDK_ERRLOG("No match cmd operation,cmd_op = %d\n", cmd_op);

		return -EINVAL;