Commit 2d35f024 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Konrad Sztyber
Browse files

test/nvmf: enable nvmf_shutdown tests 



These tests are valuable as they have caught issues in the past and
cover negative paths that might reveal subtle bugs, which should be
found sooner (per patch) rather than later (production).

Phy condition was mistakenly introduced in cbda5664.

Suppression of tc4 is likely not needed due to 0354bb8e fix, however
still needed because of #3522.

Change-Id: I8e7150946ad9ebf69b79859bad999b8d8d4c35aa
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26118


Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
parent 7c063325

test/common/skipped_tests.txt

+0 −4
Original line number Diff line number Diff line
@@ -199,10 +199,6 @@ nvmf_bdevperf 
nvmf_llvm_fuzz

nvmf_perf_adq

nvmf_rdma

nvmf_shutdown

nvmf_shutdown_tc1

nvmf_shutdown_tc2

nvmf_shutdown_tc3

nvmf_shutdown_tc4

nvmf_srq_overwhelm

nvmf_target_disconnect

test/nvmf/nvmf_target_extra.sh

+2 −1
Original line number Diff line number Diff line
@@ -63,8 +63,9 @@ if [[ $NET_TYPE == phy ]]; then 
		# run_test "nvmf_device_removal" test/nvmf/target/device_removal.sh "${TEST_ARGS[@]}"

		run_test "nvmf_srq_overwhelm" "$rootdir/test/nvmf/target/srq_overwhelm.sh" "${TEST_ARGS[@]}"

	fi

	run_test "nvmf_shutdown" $rootdir/test/nvmf/target/shutdown.sh "${TEST_ARGS[@]}"

fi



run_test "nvmf_shutdown" "$rootdir/test/nvmf/target/shutdown.sh" "${TEST_ARGS[@]}"

run_test "nvmf_nsid" "$rootdir/test/nvmf/target/nsid.sh" "${TEST_ARGS[@]}"



trap - SIGINT SIGTERM EXIT

test/nvmf/target/shutdown.sh

+3 −2
Original line number Diff line number Diff line
@@ -162,8 +162,9 @@ function nvmf_shutdown_tc4() { 
run_test "nvmf_shutdown_tc1" nvmf_shutdown_tc1

run_test "nvmf_shutdown_tc2" nvmf_shutdown_tc2

run_test "nvmf_shutdown_tc3" nvmf_shutdown_tc3

# Temporarily disable on e810 due to issue #3523

if ! [[ "$SPDK_TEST_NVMF_NICS" == "e810" && "$TEST_TRANSPORT" == "rdma" ]]; then



# Temporarily disable for tcp due to issue #3522

if [[ "$TEST_TRANSPORT" != "tcp" ]]; then

	run_test "nvmf_shutdown_tc4" nvmf_shutdown_tc4

fi