Commit 2bbc59fa authored by Ben Walker's avatar Ben Walker Committed by Daniel Verkamp
Browse files

nvmf: Fix bug when accessing realloc'd pointer 



Caught by the latest scan-build.

Change-Id: I606a30447e5221c86e79accb9a2c1fe76e9eeee0
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/396054


Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent b232bff5

lib/nvmf/nvmf.c

+2 −8
Original line number Diff line number Diff line
@@ -570,26 +570,20 @@ int 
spdk_nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group,

				      struct spdk_nvmf_subsystem *subsystem)

{

	struct spdk_nvmf_subsystem_poll_group *sgroup;

	int rc;



	if (subsystem->id >= group->num_sgroups) {

		return -1;

	}



	sgroup = &group->sgroups[subsystem->id];

	if (sgroup == NULL) {

		return -1;

	}



	assert(sgroup->state == SPDK_NVMF_SUBSYSTEM_PAUSED);

	assert(group->sgroups[subsystem->id].state == SPDK_NVMF_SUBSYSTEM_PAUSED);



	rc = poll_group_update_subsystem(group, subsystem);

	if (rc) {

		return rc;

	}



	sgroup->state = SPDK_NVMF_SUBSYSTEM_ACTIVE;

	group->sgroups[subsystem->id].state = SPDK_NVMF_SUBSYSTEM_ACTIVE;



	return 0;

}