Commit 2b8661d6 authored Mar 29, 2021 by Shuhei Matsumoto Committed by Jim Harris Apr 08, 2021

bdev/nvme: Move nvme_ctrlr_depopulate_namespace_done() to common.c



Moving nvme_ctrlr_depopulate_namespace_done() to common.c removes the
stub from bdev_ocssd_ut.c and will simplify the upcoming changes.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ia94a88ca77518c7df08b52aa9298cdea5997ca1e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7135


Community-CI: Broadcom CI
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>

parent 610dd86b

module/bdev/nvme/bdev_nvme.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1518,12 +1518,6 @@ timeout_cb(void cb_arg, struct spdk_nvme_ctrlr ctrlr,
		}
		}

		void
		nvme_ctrlr_depopulate_namespace_done(struct nvme_bdev_ns *nvme_ns)
		{
		nvme_bdev_ns_detach(nvme_ns);
		}

		static void
		nvme_ctrlr_depopulate_standard_namespace(struct nvme_bdev_ns *nvme_ns)
		{

module/bdev/nvme/common.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -204,3 +204,9 @@ nvme_bdev_ns_detach(struct nvme_bdev_ns *nvme_ns)

		nvme_bdev_ctrlr_destruct(nvme_ns->ctrlr);
		}

		void
		nvme_ctrlr_depopulate_namespace_done(struct nvme_bdev_ns *nvme_ns)
		{
		nvme_bdev_ns_detach(nvme_ns);
		}

test/unit/lib/bdev/nvme/bdev_ocssd.c/bdev_ocssd_ut.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -197,12 +197,6 @@ nvme_ctrlr_populate_namespace_done(struct nvme_async_probe_ctx *ctx,
		ns->ctrlr->ref++;
		}

		void
		nvme_ctrlr_depopulate_namespace_done(struct nvme_bdev_ns *ns)
		{
		nvme_bdev_ns_detach(ns);
		}

		static struct nvme_bdev_ctrlr *
		create_nvme_bdev_controller(const struct spdk_nvme_transport_id trid, const char name)
		{