Commit 2a5ccaca authored Jul 30, 2019 by Karol Latecki Committed by Jim Harris Aug 08, 2019

test/vhost: remove superfluous (..) around condition



Removing parentheses around if condition.
This unnecessarily spawns a subshell.

Removing SC2233 (Remove superfluous (..) around condition)
from check_format.sh exclusion list.

Change-Id: I0a4c266667264220a898ce80f587ae61bc113821
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463627


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

parent 1ccc878e

scripts/check_format.sh

+1 −1

Original line number	Diff line number	Diff line
		@@ -247,7 +247,7 @@ SC2059,SC2064,SC2068,SC2074,SC2086,SC2088,SC2089,SC2090,SC2091,SC2094,\
		SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\
		SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\
		SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,SC2178,SC2181,SC2191,SC2192,SC2195,\
		SC2199,SC2206,SC2207,SC2209,SC2214,SC2219,SC2220,SC2223,SC2230,SC2231,SC2233,SC2235"
		SC2199,SC2206,SC2207,SC2209,SC2214,SC2219,SC2220,SC2223,SC2230,SC2231,SC2235"

		SHCK_FORMAT="diff"
		SHCK_APPLY=true

test/vhost/common.sh

+1 −1

Original line number	Diff line number	Diff line
		@@ -680,7 +680,7 @@ function vm_setup()
		cmd+="-device ide-hd,drive=os_disk,bootindex=0 ${eol}"
		fi

		if ( [[ $disks == '' ]] && [[ $disk_type_g == virtio* ]] ); then
		if [[ $disks == '' ]] && [[ $disk_type_g == virtio* ]]; then
		disks=1
		fi