Commit 29b3da96 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki
Browse files

socket: removed deprecated zerocopy RPC options 



Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I748c3f008a6ba1b969acecdd593940077800091b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8900


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarMonica Kenguva <monica.kenguva@intel.com>
Reviewed-by: default avatarGangCao <gang.cao@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent c97eb5ec

CHANGELOG.md

+5 −0
Original line number Diff line number Diff line
@@ -146,6 +146,11 @@ provided in `scripts/rpc.py` for consistency. 
An new optional parameter `config_kernel_mode` was added to the RPC `idxd_scan_accel_engine`,

and this is used to enable using the kernel mode IDXD driver.



Removed deprecated parameter `enable-zerocopy-send` of RPC `sock_impl_set_options`,

use `enable-zerocopy-send-server` or `enable-zerocopy-send-client` instead.

Removed deprecated parameter `disable-zerocopy-send` of RPC `sock_impl_set_options`,

use `disable-zerocopy-send-server` or `disable-zerocopy-send-client` instead.



### rpm



Removed deprecated `pkg/spdk.spec`, please use `rpmbuild/spdk.spec` instead.

deprecation.md

+0 −7
Original line number Diff line number Diff line
@@ -11,10 +11,3 @@ Specific future SPDK release for the removal must be provided. 
ABI cannot be removed without providing deprecation notice for at least single SPDK release.



# Deprecation Notices {#deprecation-notices}
 


## rpc



Parameter `enable-zerocopy-send` of RPC `sock_impl_set_options` is deprecated and will be removed in SPDK 21.07,

use `enable-zerocopy-send-server` or `enable-zerocopy-send-client` instead.

Parameter `disable-zerocopy-send` of RPC `sock_impl_set_options` is deprecated and will be removed in SPDK 21.07,

use `disable-zerocopy-send-server` or `disable-zerocopy-send-client` instead.

scripts/rpc.py

+0 −6
Original line number Diff line number Diff line
@@ -2653,12 +2653,6 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
                   action='store_true', dest='enable_recv_pipe')

    p.add_argument('--disable-recv-pipe', help='Disable receive pipe',

                   action='store_false', dest='enable_recv_pipe')

    p.add_argument('--enable-zerocopy-send', help="""Enable zerocopy on send

    (Deprecated, use enable-zerocopy-send-server or enable-zerocopy-send-client)""",

                   action='store_true', dest='enable_zerocopy_send')

    p.add_argument('--disable-zerocopy-send', help="""Enable zerocopy on send

    (Deprecated, use disable-zerocopy-send-server or disable-zerocopy-send-client)""",

                   action='store_false', dest='enable_zerocopy_send')

    p.add_argument('--enable-quickack', help='Enable quick ACK',

                   action='store_true', dest='enable_quickack')

    p.add_argument('--disable-quickack', help='Disable quick ACK',