Commit 29784f35 authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Tomasz Zawadzki
Browse files

bdevperf: promote bdevperf from test to example application 



bdevperf application is utilized in multiple test scenarios
and most prominently in SPDK performance reports.
Similar to perf and fio_plugins, it is used to measure performance.
It is intended to represent the expected behavior of users
application that use SPDK bdev layer.

Applications under --enable-tests are intended for specific test
scenarios and user interaction is usually via a test scripts.
Meanwhile --enable-examples are used more broadly to teach and
show usage of SPDK libraries.

As an added benefit with this patch, its possible to compile
bdevperf without need to satisfy additional requirements to
compile all the test applications.

Change-Id: I9aaec1f9d729a1cdee89b5fdc365d61c19b03f82
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14558


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent e2085b84

CHANGELOG.md

+5 −0
Original line number Diff line number Diff line
@@ -44,6 +44,11 @@ names with this option to restrict allowed RPCs to only that list. 


Added spdk_rpc_set_allowlist to restrict allowed RPCs to the specified list.



### bdevperf



Promoted the application to example to match similar programs: fio_plugin and perf.

It can now be found inside `examples/bdev/bdevperf`.



## v22.09



### accel

doc/nvmf_multipath_howto.md

+2 −2
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ Add two listeners, each with a different `IP:port` pair: 
Launch the bdevperf process in the background:

~~~{.sh}

cd spdk/

./test/bdev/bdevperf/bdevperf -m 0x4 -z -r /tmp/bdevperf.sock -q 128 -o 4096 -w verify -t 90 &> bdevperf.log &

./build/examples/bdevperf -m 0x4 -z -r /tmp/bdevperf.sock -q 128 -o 4096 -w verify -t 90 &> bdevperf.log &

~~~



Configure bdevperf and add two paths:
@@ -71,7 +71,7 @@ Configure bdevperf and add two paths: 


Connect to the RPC socket of the bdevperf process and start the test:

~~~{.sh}

PYTHONPATH=$PYTHONPATH:/root/src/spdk/python ./test/bdev/bdevperf/bdevperf.py -t 1 -s /tmp/bdevperf.sock perform_tests

PYTHONPATH=$PYTHONPATH:/root/src/spdk/python ./examples/bdev/bdevperf/bdevperf.py -t 1 -s /tmp/bdevperf.sock perform_tests

~~~



The RPC command will return, leaving the test to run for 90 seconds in the background. On the target server,

examples/bdev/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..) 
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk



DIRS-$(CONFIG_FIO_PLUGIN) = fio_plugin

DIRS-y += hello_world

DIRS-y += hello_world bdevperf



.PHONY: all clean $(DIRS-y)