Commit 29416c0a authored by Artsiom Koltun's avatar Artsiom Koltun Committed by Tomasz Zawadzki
Browse files

sma: report device level QoS capabilities for virtio-blk. 



Virtio-blk supports one to one mapping between devices and volumes.
Based on that, we can report underlying bdev capabilities as device
level QoS capabilities.

Signed-off-by: default avatarArtsiom Koltun <artsiom.koltun@intel.com>
Change-Id: If7c28c75d087fecec0105002994581fd7ac57f51
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15260


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 51ab849b

python/spdk/sma/device/vhost_blk.py

+3 −1
Original line number Diff line number Diff line
@@ -219,4 +219,6 @@ class VhostBlkDeviceManager(DeviceManager): 
                                  'Failed to set QoS')



    def get_qos_capabilities(self, request):

        return qos.get_bdev_qos_capabilities()
 
        bdev_caps = qos.get_bdev_qos_capabilities().max_volume_caps

        return sma_pb2.GetQosCapabilitiesResponse(max_volume_caps=bdev_caps,

                                                  max_device_caps=bdev_caps)

test/sma/vhost_blk.sh

+6 −0
Original line number Diff line number Diff line
@@ -203,6 +203,12 @@ device=$(create_device 0 $uuid | jq -r '.handle') 
diff <(get_qos_caps $device_vhost | jq --sort-keys) <(

	jq --sort-keys <<- CAPS

		{

		  "max_device_caps": {

		    "rw_iops": true,

		    "rd_bandwidth": true,

		    "wr_bandwidth": true,

		    "rw_bandwidth": true

		  },

		  "max_volume_caps": {

		    "rw_iops": true,

		    "rd_bandwidth": true,