Commit 28ebb8cc authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

bdev_module: remove config_text 



This patch removes function for bdev modules to
present options of the bdevs.

blob_bdev.h refers to the spdk_bdev_module, so would need
to be bumped too.
At this time spdk_bdev_module is left unchanged to prevent
that.

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I3cacb087c998d928c5d8c2722b7f041d82bb43f1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4748


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI
parent bd3840a7

CHANGELOG.md

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ A new `spdk_bdev_part_base_construct_ext` function has been added and the 
of bdev structure to avoid a race condition that can happen when the bdev is being

removed between a call to get its structure based on a name and actually openning it.



Removed `spdk_bdev_config_text` function for bdev modules to report legacy config.



### blobstore



A new `spdk_bdev_create_bs_dev_ext` function has been added and `spdk_bdev_create_bs_dev_from_desc`

include/spdk/bdev.h

+0 −7
Original line number Diff line number Diff line
@@ -242,13 +242,6 @@ void spdk_bdev_initialize(spdk_bdev_init_cb cb_fn, void *cb_arg); 
 */

void spdk_bdev_finish(spdk_bdev_fini_cb cb_fn, void *cb_arg);



/**

 * Get the configuration options for the registered block device modules.

 *

 * \param fp The pointer to a file that will be written to the configuration options.

 */

void spdk_bdev_config_text(FILE *fp);



/**

 * Get the full configuration options for the registered block device modules and created bdevs.

 *

include/spdk/bdev_module.h

+1 −0
Original line number Diff line number Diff line
@@ -88,6 +88,7 @@ struct spdk_bdev_module { 
	/**

	 * Function called to return a text string representing the

	 * module's configuration options for inclusion in a configuration file.

	 * (Deprecated and shall not be called by bdev layer)

	 */

	void (*config_text)(FILE *fp);

lib/bdev/Makefile

+2 −2
Original line number Diff line number Diff line
@@ -34,8 +34,8 @@ 
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)

include $(SPDK_ROOT_DIR)/mk/spdk.common.mk



SO_VER := 3

SO_MINOR := 1

SO_VER := 4

SO_MINOR := 0



ifeq ($(CONFIG_VTUNE),y)

CFLAGS += -I$(CONFIG_VTUNE_DIR)/include -I$(CONFIG_VTUNE_DIR)/sdk/src/ittnotify

lib/bdev/bdev.c

+0 −12
Original line number Diff line number Diff line
@@ -981,18 +981,6 @@ bdev_module_get_max_ctx_size(void) 
	return max_bdev_module_size;

}



void

spdk_bdev_config_text(FILE *fp)

{

	struct spdk_bdev_module *bdev_module;



	TAILQ_FOREACH(bdev_module, &g_bdev_mgr.bdev_modules, internal.tailq) {

		if (bdev_module->config_text) {

			bdev_module->config_text(fp);

		}

	}

}



static void

bdev_qos_config_json(struct spdk_bdev *bdev, struct spdk_json_write_ctx *w)

{