Commit 277dbc96 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

bdev/nvme: implement accel sequence callbacks 



For now these include functions required for managing an accel sequence:
finish, reverse, and abort, as well as a callback for appending a crc32c
operation.  Additional callbacks can be added as needed at a later date.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ic9d37bddc295eb4456707be6cd56294b4ac166ae
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18764


Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent c3f7adb0

module/bdev/nvme/bdev_nvme.c

+39 −0
Original line number Diff line number Diff line
@@ -3302,9 +3302,48 @@ bdev_nvme_submit_accel_crc32c(void *ctx, uint32_t *dst, struct iovec *iov, 
	}

}



static void

bdev_nvme_finish_sequence(void *seq, spdk_nvme_accel_completion_cb cb_fn, void *cb_arg)

{

	spdk_accel_sequence_finish(seq, cb_fn, cb_arg);

}



static void

bdev_nvme_abort_sequence(void *seq)

{

	spdk_accel_sequence_abort(seq);

}



static void

bdev_nvme_reverse_sequence(void *seq)

{

	spdk_accel_sequence_reverse(seq);

}



static int

bdev_nvme_append_crc32c(void *ctx, void **seq, uint32_t *dst, struct iovec *iovs, uint32_t iovcnt,

			struct spdk_memory_domain *domain, void *domain_ctx, uint32_t seed,

			spdk_nvme_accel_step_cb cb_fn, void *cb_arg)

{

	struct spdk_io_channel *ch;

	struct nvme_poll_group *group = ctx;



	ch = bdev_nvme_get_accel_channel(group);

	if (spdk_unlikely(ch == NULL)) {

		return -ENOMEM;

	}



	return spdk_accel_append_crc32c((struct spdk_accel_sequence **)seq, ch, dst, iovs, iovcnt,

					domain, domain_ctx, seed, cb_fn, cb_arg);

}



static struct spdk_nvme_accel_fn_table g_bdev_nvme_accel_fn_table = {

	.table_size		= sizeof(struct spdk_nvme_accel_fn_table),

	.submit_accel_crc32c	= bdev_nvme_submit_accel_crc32c,

	.append_crc32c		= bdev_nvme_append_crc32c,

	.finish_sequence	= bdev_nvme_finish_sequence,

	.reverse_sequence	= bdev_nvme_reverse_sequence,

	.abort_sequence		= bdev_nvme_abort_sequence,

};



static int

test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c

+8 −0
Original line number Diff line number Diff line
@@ -228,6 +228,14 @@ DEFINE_STUB_V(spdk_opal_dev_destruct, (struct spdk_opal_dev *dev)); 
DEFINE_STUB(spdk_accel_submit_crc32cv, int, (struct spdk_io_channel *ch, uint32_t *dst,

		struct iovec *iov,

		uint32_t iov_cnt, uint32_t seed, spdk_accel_completion_cb cb_fn, void *cb_arg), 0);

DEFINE_STUB(spdk_accel_append_crc32c, int,

	    (struct spdk_accel_sequence **seq, struct spdk_io_channel *ch, uint32_t *dst,

	     struct iovec *iovs, uint32_t iovcnt, struct spdk_memory_domain *domain, void *domain_ctx,

	     uint32_t seed, spdk_accel_step_cb cb_fn, void *cb_arg), 0);

DEFINE_STUB_V(spdk_accel_sequence_finish,

	      (struct spdk_accel_sequence *seq, spdk_accel_completion_cb cb_fn, void *cb_arg));

DEFINE_STUB_V(spdk_accel_sequence_abort, (struct spdk_accel_sequence *seq));

DEFINE_STUB_V(spdk_accel_sequence_reverse, (struct spdk_accel_sequence *seq));



struct ut_nvme_req {

	uint16_t			opc;