Commit 26c2f987 authored by Michal Berger's avatar Michal Berger Committed by Tomasz Zawadzki
Browse files

test/setup: Use hw_sector_size to convert size to sectors 



The {logical,physical}_block_size may actually differ (physical can
be bigger than logical) so always use the smallest available unit -
the hw_sector_size is an actual alias to logical_block_size and it's
also clearly indicating what unit sgdisk is working with.

In case the physical_block_size differs, the resulted partitions may
have different size than expected. For instance, under nvme with
512/4096 layout, the partitions were ending up 128MB in size instead
of 1GB causing the dmsetup to fail (as it expects to join partitions
1GB in size each).

Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Change-Id: Ib6d3afd3471af2c2e9a5ced17004dd9c565708c8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16551


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent b25f6304

test/setup/common.sh

+1 −1
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ partition_drive() { 
	done



	# Convert size to sectors for more precise partitioning

	((size /= $(< "/sys/class/block/$disk/queue/physical_block_size")))

	((size /= $(< "/sys/class/block/$disk/queue/hw_sector_size")))



	"$rootdir/scripts/sync_dev_uevents.sh" block/partition "${parts[@]}" &