Commit 267318d6 authored by Dariusz Stojaczyk's avatar Dariusz Stojaczyk Committed by Daniel Verkamp
Browse files

bdev/virtio: fix memleak in construct_virtio_user_blk_bdev 



Fixes #305

Change-Id: I70843e63c74761e71cbe39369249cfa1123a4275
Signed-off-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/411959


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarPawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent b0cfbb4f

lib/bdev/virtio/bdev_virtio_rpc.c

+2 −1
Original line number Diff line number Diff line
@@ -331,11 +331,13 @@ spdk_rpc_create_virtio_user_blk_bdev(struct spdk_jsonrpc_request *request, 
	if (spdk_json_decode_object(params, rpc_construct_virtio_user_blk_dev,

				    SPDK_COUNTOF(rpc_construct_virtio_user_blk_dev),

				    &req)) {

		free_rpc_construct_virtio_blk_dev(&req);

		rc = -EINVAL;

		goto invalid;

	}



	bdev = bdev_virtio_user_blk_dev_create(req.name, req.path, req.vq_count, req.vq_size);

	free_rpc_construct_virtio_blk_dev(&req);

	if (bdev == NULL) {

		rc = -EINVAL;

		goto invalid;
@@ -355,7 +357,6 @@ spdk_rpc_create_virtio_user_blk_bdev(struct spdk_jsonrpc_request *request, 
invalid:

	spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,

					 spdk_strerror(-rc));

	free_rpc_construct_virtio_blk_dev(&req);

}

SPDK_RPC_REGISTER("construct_virtio_user_blk_bdev", spdk_rpc_create_virtio_user_blk_bdev,

		  SPDK_RPC_RUNTIME);