Commit 266ca940 authored by Seth Howell's avatar Seth Howell Committed by Changpeng Liu
Browse files

Revert "shared_lib: add as_needed to the libspdk.so linker script"



This reverts commit 346fefc3.
That commit breaks the shared object build when linking against the
implicit top level linker script. It makes it so that none of the
constructor functions get properly linked in.

Change-Id: I3477acbd86f44b6d5e949eb6725ca4c1b71a55b5
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462149


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 4edb785f
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ SPDK_SHARED_LIBS := $(filter-out $(IGNORED_LIBS), $(sort $(notdir $(wildcard $(S

$(SHARED_REALNAME_LIB):
	$(Q)echo "  SO $(notdir $@)"; \
	echo "GROUP ( AS_NEEDED ( $(SPDK_SHARED_LIBS) ) )" > $(SHARED_REALNAME_LIB)
	echo "GROUP ( $(SPDK_SHARED_LIBS) )" > $(SHARED_REALNAME_LIB)

$(SHARED_LINKED_LIB) : $(SHARED_REALNAME_LIB)
	$(Q)echo "  SYMLINK $(notdir $@)"; $(BUILD_LINKERNAME_LIB)