Commit 262ecf0e authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

nvmf/tcp: stop trying to accept when no more socks 



The loop is intended to accept multiple socks when
available, but once accept returns NULL, there's no
reason to keep trying.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I896908d276da35bc3fff172c1c17e22abd2a5343

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/473234


Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 2a8dc3e9

lib/nvmf/tcp.c

+3 −2
Original line number Diff line number Diff line
@@ -1151,9 +1151,10 @@ spdk_nvmf_tcp_port_accept(struct spdk_nvmf_transport *transport, struct spdk_nvm 


	for (i = 0; i < NVMF_TCP_MAX_ACCEPT_SOCK_ONE_TIME; i++) {

		sock = spdk_sock_accept(port->listen_sock);

		if (sock) {

			_spdk_nvmf_tcp_handle_connect(transport, port, sock, cb_fn, cb_arg);

		if (sock == NULL) {

			break;

		}

		_spdk_nvmf_tcp_handle_connect(transport, port, sock, cb_fn, cb_arg);

	}

}