Commit 242a8995 authored by Darek Stojaczyk's avatar Darek Stojaczyk Committed by Tomasz Zawadzki
Browse files

autobuild: don't silence errtrap with leading ! 



Apparently some shellcheck versions on our CI complain about it
and suggest to use && exit 1 instead, we'll try to use || true
instead.

Change-Id: Idb505770a80929fbb9957f4ba039e009aae98f02
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/835


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 9e33ad75

autobuild.sh

+2 −2
Original line number Diff line number Diff line
@@ -72,8 +72,8 @@ function scanbuild_make { 
	# from comm manual:

	#   -2 suppress column 2 (lines unique to FILE2)

	#   -3 suppress column 3 (lines that appear in both files)

	# comm may exit 1 if no lines were printed (undocumented)

	! comm -2 -3 $out/all_c_files.txt $out/built_c_files.txt > $out/unbuilt_c_files.txt

	# comm may exit 1 if no lines were printed (undocumented, unreliable)

	comm -2 -3 $out/all_c_files.txt $out/built_c_files.txt > $out/unbuilt_c_files.txt || true



	if [ $(wc -l < $out/unbuilt_c_files.txt) -ge 1 ]; then

		echo "missing files"