Commit 23975858 authored by Evgeniy Kochetov's avatar Evgeniy Kochetov Committed by Jim Harris
Browse files

ut/bdev: Add tests for device close and unregister 



Signed-off-by: default avatarEvgeniy Kochetov <evgeniik@mellanox.com>
Signed-off-by: default avatarSasha Kotchubievsky <sashakot@mellanox.com>
Signed-off-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Change-Id: Ia2615a00785c60e10fb893e75dd68198fbf84ff3
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469619


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 437e54f7

test/unit/lib/bdev/bdev.c/bdev_ut.c

+45 −0
Original line number Diff line number Diff line
@@ -67,6 +67,8 @@ int g_count; 
enum spdk_bdev_event_type g_event_type1;

enum spdk_bdev_event_type g_event_type2;

struct spdk_histogram_data *g_histogram;

void *g_unregister_arg;

int g_unregister_rc;



void

spdk_scsi_nvme_translate(const struct spdk_bdev_io *bdev_io,
@@ -416,6 +418,13 @@ get_device_stat_cb(struct spdk_bdev *bdev, struct spdk_bdev_io_stat *stat, void 
	*(bool *)cb_arg = true;

}



static void

bdev_unregister_cb(void *cb_arg, int rc)

{

	g_unregister_arg = cb_arg;

	g_unregister_rc = rc;

}



static void

bdev_open_cb1(enum spdk_bdev_event_type type, struct spdk_bdev *bdev, void *event_ctx)

{
@@ -2018,6 +2027,41 @@ bdev_open_while_hotremove(void) 
	free_bdev(bdev);

}



static void

bdev_close_while_hotremove(void)

{

	struct spdk_bdev *bdev;

	struct spdk_bdev_desc *desc = NULL;

	int rc = 0;



	bdev = allocate_bdev("bdev");



	rc = spdk_bdev_open_ext("bdev", true, bdev_open_cb1, &desc, &desc);

	CU_ASSERT_EQUAL(rc, 0);



	/* Simulate hot-unplug by unregistering bdev */

	g_event_type1 = 0xFF;

	g_unregister_arg = NULL;

	g_unregister_rc = -1;

	spdk_bdev_unregister(bdev, bdev_unregister_cb, (void *)0x12345678);

	/* Close device while remove event is in flight */

	spdk_bdev_close(desc);



	/* Ensure that unregister callback is delayed */

	CU_ASSERT_EQUAL(g_unregister_arg, NULL);

	CU_ASSERT_EQUAL(g_unregister_rc, -1);



	poll_threads();



	/* Event callback shall not be issued because device was closed */

	CU_ASSERT_EQUAL(g_event_type1, 0xFF);

	/* Unregister callback is issued */

	CU_ASSERT_EQUAL(g_unregister_arg, (void *)0x12345678);

	CU_ASSERT_EQUAL(g_unregister_rc, 0);



	free_bdev(bdev);

}



static void

bdev_open_ext(void)

{
@@ -2085,6 +2129,7 @@ main(int argc, char **argv) 
		CU_add_test(suite, "bdev_histograms", bdev_histograms) == NULL ||

		CU_add_test(suite, "bdev_write_zeroes", bdev_write_zeroes) == NULL ||

		CU_add_test(suite, "bdev_open_while_hotremove", bdev_open_while_hotremove) == NULL ||

		CU_add_test(suite, "bdev_close_while_hotremove", bdev_close_while_hotremove) == NULL ||

		CU_add_test(suite, "bdev_open_ext", bdev_open_ext) == NULL

	) {

		CU_cleanup_registry();