Commit 227b8322 authored by Marcin Spiewak's avatar Marcin Spiewak Committed by Jim Harris
Browse files

module/sock: free addr info before return 



Fixed issue found by Coverity.
In some cases, uring_sock_create() and
posix_sock_create() functions were not freeing
resources before exiting. Now it is fixed.

Change-Id: I2fef551a1384335597e12aa57a9cd2ce3686c4c2
Signed-off-by: default avatarMarcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24486


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent 29119cdf

module/sock/posix/posix.c

+2 −0
Original line number Diff line number Diff line
@@ -1043,6 +1043,8 @@ retry: 
						    src_addr ? src_addr : "", portnum);

					close(fd);

					fd = -1;

					freeaddrinfo(src_ai);

					src_ai = NULL;

					break;

				}

				freeaddrinfo(src_ai);

module/sock/uring/uring.c

+2 −0
Original line number Diff line number Diff line
@@ -652,6 +652,8 @@ retry: 
						    src_addr ? src_addr : "", portnum);

					close(fd);

					fd = -1;

					freeaddrinfo(src_ai);

					src_ai = NULL;

					break;

				}

				freeaddrinfo(src_ai);