Commit 218dcd84 authored by Jim Harris's avatar Jim Harris Committed by Daniel Verkamp
Browse files

bdev/pmem: change all NVML strings to PMDK 



NVML (Non Volatile Memory Library) changed its name to
PMDK (Persistent Memory Development Kit), so make the
necessary changes to the SPDK repository.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Id07a87eafb4e9a3099603030c58c0e927bafa608

Reviewed-on: https://review.gerrithub.io/406256


Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
parent 6e1611da

CHANGELOG.md

+6 −0
Original line number Diff line number Diff line
@@ -70,6 +70,12 @@ An iSCSI initiator bdev module has been added to SPDK. This module should be co 
experimental pending additional features and tests.  More details can be found in

lib/bdev/iscsi/README.



### PMDK



The persistent memory (PMDK) bdev module is now enabled using --with-pmdk instead of

--with-nvml.  This reflects the renaming of the persistent memory library from NVML to

PMDK.



## v18.01: Blobstore Thin Provisioning



### Build System

CONFIG

+2 −2
Original line number Diff line number Diff line
@@ -90,8 +90,8 @@ CONFIG_VHOST?=y 
# Build vhost initiator (Virtio) driver.

CONFIG_VIRTIO?=y



# Build with NVML backends

CONFIG_NVML?=n

# Build with PMDK backends

CONFIG_PMDK?=n



# Build with VPP

CONFIG_VPP?=n

autotest.sh

+1 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ if [ $SPDK_TEST_VHOST_INIT -eq 1 ]; then 
	report_test_completion "vhost_initiator"

fi



if [ $SPDK_TEST_NVML -eq 1 ]; then

if [ $SPDK_TEST_PMDK -eq 1 ]; then

	run_test ./test/pmem/pmem.sh -x

fi

configure

+13 −13
Original line number Diff line number Diff line
@@ -39,8 +39,8 @@ function usage() 
	echo "                           No path required."

	echo " virtio                    Required to build vhost initiator (Virtio) bdev module."

	echo "                           No path required."

	echo " nvml                      Required to build persistent memory bdev."

	echo "                           example: /usr/share/nvml"

	echo " pmdk                      Required to build persistent memory bdev."

	echo "                           example: /usr/share/pmdk"

	echo " vpp                       Required to build VPP net module."

	echo "                           example: /vpp_repo/build-root/install-vpp-native/vpp"

	echo " rbd                       [disabled]"
@@ -167,16 +167,16 @@ for i in "$@"; do 
		--without-virtio)

			CONFIG_VIRTIO=n

			;;

		--with-nvml)

			CONFIG_NVML=y

		--with-pmdk)

			CONFIG_PMDK=y

			;;

		--with-nvml=*)

			CONFIG_NVML=y

		--with-pmdk=*)

			CONFIG_PMDK=y

			check_dir "$i"

			CONFIG_NVML_DIR=$(readlink -f ${i#*=})

			CONFIG_PMDK_DIR=$(readlink -f ${i#*=})

			;;

		--without-nvml)

			CONFIG_NVML=n

		--without-pmdk)

			CONFIG_PMDK=n

			;;

		--with-vpp)

			CONFIG_VPP=y
@@ -300,11 +300,11 @@ fi 
if [ -n "$CONFIG_VIRTIO" ]; then

	echo "CONFIG_VIRTIO?=$CONFIG_VIRTIO" >> CONFIG.local

fi

if [ -n "$CONFIG_NVML" ]; then

	echo "CONFIG_NVML?=$CONFIG_NVML" >> CONFIG.local

if [ -n "$CONFIG_PMDK" ]; then

	echo "CONFIG_PMDK?=$CONFIG_PMDK" >> CONFIG.local

fi

if [ -n "$CONFIG_NVML_DIR" ]; then

	echo "CONFIG_NVML_DIR?=$CONFIG_NVML_DIR" >> CONFIG.local

if [ -n "$CONFIG_PMDK_DIR" ]; then

	echo "CONFIG_PMDK_DIR?=$CONFIG_PMDK_DIR" >> CONFIG.local

fi

if [ -n "$CONFIG_VPP" ]; then

	echo "CONFIG_VPP?=$CONFIG_VPP" >> CONFIG.local

doc/bdev.md

+2 −2
Original line number Diff line number Diff line
@@ -250,9 +250,9 @@ Example commands 


The SPDK pmem bdev driver uses pmemblk pool as the target for block I/O operations. For

details on Pmem memory please refer to PMDK documentation on http://pmem.io website.

First, user needs to compile SPDK with NVML library:

First, user needs to configure SPDK to include PMDK support:



`configure --with-nvml`

`configure --with-pmdk`



To create pmemblk pool for use with SPDK user should use `create_pmem_pool` RPC command.