Commit 21828e4a authored by Wojciech Panfil's avatar Wojciech Panfil Committed by Tomasz Zawadzki
Browse files

bdevperf/nvme_perf/hello_world: Add fflush(stdout) 



In case the app hangs in cleanup/fini, most likely stdout will not get
printed out (buffered) therefore no logs will be visible.
This change shouldn't harm performance as fflush() is performed after
the test itself.

Change-Id: I7d12ae037de5b686c776de8d66c5cbec5df6a544
Signed-off-by: default avatarWojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23022


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
parent 7692207e

app/spdk_nvme_perf/perf.c

+2 −0
Original line number Diff line number Diff line
@@ -3327,6 +3327,8 @@ main(int argc, char **argv) 
	pthread_barrier_destroy(&g_worker_sync_barrier);



cleanup:

	fflush(stdout);



	if (thread_id && pthread_cancel(thread_id) == 0) {

		pthread_join(thread_id, NULL);

	}

examples/bdev/bdevperf/bdevperf.c

+2 −2
Original line number Diff line number Diff line
@@ -653,8 +653,6 @@ bdevperf_test_done(void *ctx) 
	}

	printf(" %10.2f %10.2f %10.2f\n", average_latency, g_stats.min_latency, g_stats.max_latency);



	fflush(stdout);



	if (g_latency_display_level == 0 || g_stats.total_io_completed == 0) {

		goto clean;

	}
@@ -687,6 +685,8 @@ bdevperf_test_done(void *ctx) 
	}



clean:

	fflush(stdout);



	TAILQ_FOREACH_SAFE(job, &g_bdevperf.jobs, link, jtmp) {

		TAILQ_REMOVE(&g_bdevperf.jobs, job, link);

examples/nvme/hello_world/hello_world.c

+1 −0
Original line number Diff line number Diff line
@@ -504,6 +504,7 @@ main(int argc, char **argv) 
	hello_world();



exit:

	fflush(stdout);

	cleanup();

	if (g_vmd) {

		spdk_vmd_fini();