Commit 2112c8bf authored by Ben Walker's avatar Ben Walker Committed by Tomasz Zawadzki
Browse files

nvmf/tcp: Remove pdu ref count 



This wasn't actually used. Every PDU only had a single reference.

Change-Id: I8adaa7edeca5fe175aa853c156df741170d76c10
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/479902


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 52f1e4b0

include/spdk_internal/nvme_tcp.h

+0 −1
Original line number Diff line number Diff line
@@ -107,7 +107,6 @@ struct nvme_tcp_pdu { 
	uint8_t						ch_valid_bytes;

	uint8_t						psh_valid_bytes;

	uint8_t						psh_len;

	int						ref;



	nvme_tcp_qpair_xfer_complete_cb			cb_fn;

	void						*cb_arg;

lib/nvmf/tcp.c

+2 −12
Original line number Diff line number Diff line
@@ -328,7 +328,6 @@ spdk_nvmf_tcp_pdu_get(struct spdk_nvmf_tcp_qpair *tqpair) 
	TAILQ_REMOVE(&tqpair->free_queue, pdu, tailq);

	memset(pdu, 0, sizeof(*pdu));

	pdu->qpair = tqpair;

	pdu->ref = 1;

	pdu->hdr = &pdu->hdr_mem;



	return pdu;
@@ -337,18 +336,9 @@ spdk_nvmf_tcp_pdu_get(struct spdk_nvmf_tcp_qpair *tqpair) 
static void

spdk_nvmf_tcp_pdu_put(struct spdk_nvmf_tcp_qpair *tqpair, struct nvme_tcp_pdu *pdu)

{

	if (!pdu) {

		return;

	}



	assert(pdu->ref > 0);



	pdu->ref--;

	if (pdu->ref == 0) {

	tqpair->free_pdu_num++;

	TAILQ_INSERT_HEAD(&tqpair->free_queue, pdu, tailq);

}

}



static struct spdk_nvmf_tcp_req *

spdk_nvmf_tcp_req_get(struct spdk_nvmf_tcp_qpair *tqpair)