Commit 2077fbd7 authored by Igor Konopko's avatar Igor Konopko Committed by Jim Harris
Browse files

nvme: do not fail init when Intel log pages are not supported 



Currently for all the Intel drives nvme driver tries
to add Intel VS log pages support. When this log pages
are not supported whole init process fails.

This patch changes this behaviour by allowing to init
Intel drives which rejects VS log pages. This is valid
scenario for drives which are in states other than
healthy. Such a drives are still accesible via admin
queue, but does not expose some of the features, such
as this particular VS log pages.

Change-Id: I3764f2d67fd7153b6b1889273a9fedeb9c4213d3
Signed-off-by: default avatarIgor Konopko <igor.j.konopko@intel.com>
Reviewed-on: https://review.gerrithub.io/c/437162


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent e3c26a05

lib/nvme/nvme_ctrlr.c

+2 −2
Original line number Diff line number Diff line
@@ -405,8 +405,8 @@ static int nvme_ctrlr_set_intel_support_log_pages(struct spdk_nvme_ctrlr *ctrlr) 


	if (spdk_nvme_wait_for_completion(ctrlr->adminq, &status)) {

		spdk_free(log_page_directory);

		SPDK_ERRLOG("nvme_ctrlr_cmd_get_log_page failed!\n");

		return -ENXIO;

		SPDK_WARNLOG("Intel log pages not supported on Intel drive!\n");

		return 0;

	}



	nvme_ctrlr_construct_intel_support_log_page_list(ctrlr, log_page_directory);