Commit 1ff3715d authored by Josh Soref's avatar Josh Soref Committed by Tomasz Zawadzki
Browse files

spelling: scripts 



Part of #2256

* available
* classes
* coalesce
* configuration
* controller
* currently
* dependencies
* different
* displaying
* does not
* environment
* explicitly
* hugepages
* ignoring
* inflight
* initialize
* parameters
* priority
* properties
* recovery
* subsystem
* subsystems
* template
* the same
* underlying
* usable
* values

Change-Id: Ibc8567af288c9f4641563835e16bf88949ba6a71
Signed-off-by: default avatarJosh Soref <jsoref@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10408


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent cc6920a4

scripts/bash-completion/spdk

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ _get_help_pos() { 


	# Fetch all the positional parameters, i.e. get first word prefixed

	# with 20h x 2. This may not be 100% accurate. Also, it won't return

	# any usuable strings, it's just meant to point out what type of

	# any usable strings, it's just meant to point out what type of

	# mandatory argument given method depends on, like bdev_name, etc.

	# TODO: separate completion for such arguments, e.g., get all bdevs

	# for parameter like bdev_name?

scripts/bpf/trace.py

+3 −3
Original line number Diff line number Diff line
@@ -475,7 +475,7 @@ class SPDKObject: 
    """Describes a specific type of an SPDK objects (e.g. qpair, thread, etc.)"""

    @dataclass

    class Lifetime:

        """Describes a lifetime and properites of a particular SPDK object."""

        """Describes a lifetime and properties of a particular SPDK object."""

        begin: int

        end: int

        ptr: int
@@ -486,7 +486,7 @@ class SPDKObject: 
        for name in tpoints:

            tpoint = next((t for t in trace.tpoints.values() if t.name == name), None)

            if tpoint is None:

                # Some tpoints might be undefined if configured without specific subystems

                # Some tpoints might be undefined if configured without specific subsystems

                continue

            self.tpoints[tpoint.id] = tpoint
@@ -496,7 +496,7 @@ class SPDKObject: 


    def annotate(self, entry: TraceEntry):

        """Annotates a tpoint entry and returns a dict indexed by argname with values representing

        various object properites.  For instance, {"qpair": {"qid": 1, "subnqn": "nqn"}} could be

        various object properties.  For instance, {"qpair": {"qid": 1, "subnqn": "nqn"}} could be

        returned to annotate an argument called "qpair" with two items: "qid" and "subnqn".

        """

        if entry.tpoint.id not in self.tpoints:

scripts/ceph/ceph.conf

+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ 
        journal_max_write_bytes=1048576000

        journal_queue_max_bytes=1048576000

        ms_dispatch_throttle_bytes=1048576000

        objecter_infilght_op_bytes=1048576000

        objecter_inflight_op_bytes=1048576000

        filestore_max_sync_interval=10

        osd_client_message_size_cap = 0

        osd_client_message_cap = 0

scripts/perf/nvmf/run_nvmf.py

+5 −5
Original line number Diff line number Diff line
@@ -119,7 +119,7 @@ class Server: 
                self.log_print("%s resulted in error: %s" % (e.cmd, e.output))



    def adq_configure_tc(self):

        self.log_print("Configuring ADQ Traffic classess and filters...")

        self.log_print("Configuring ADQ Traffic classes and filters...")



        if self.mode == "kernel":

            self.log_print("WARNING: ADQ setup not yet supported for Kernel mode. Skipping configuration.")
@@ -160,7 +160,7 @@ class Server: 
            self.log_print("%s" % tc_disk_out)

            self.log_print("%s" % tc_filter_out)



            # Ethtool coalese settings must be applied after configuring traffic classes

            # Ethtool coalesce settings must be applied after configuring traffic classes

            self.exec_cmd(["sudo", "ethtool", "--coalesce", nic_name, "adaptive-rx", "off", "rx-usecs", "0"])

            self.exec_cmd(["sudo", "ethtool", "--coalesce", nic_name, "adaptive-tx", "off", "tx-usecs", "500"])
@@ -256,7 +256,7 @@ class Server: 


    def configure_tuned(self):

        if not self.tuned_profile:

            self.log_print("WARNING: Tuned profile not set in configration file. Skipping configuration.")

            self.log_print("WARNING: Tuned profile not set in configuration file. Skipping configuration.")

            return



        self.log_print("Configuring tuned-adm profile to %s." % self.tuned_profile)
@@ -517,7 +517,7 @@ class Target(Server): 
                rw_mixread = float(re.search(r"m_(\d+)", job_name).group(1)) / 100



            # If "_CPU" exists in name - ignore it

            # Initiators for the same job could have diffrent num_cores parameter

            # Initiators for the same job could have different num_cores parameter

            job_name = re.sub(r"_\d+CPU", "", job_name)

            job_result_files = [x for x in json_files if x.startswith(job_name)]

            self.log_print("Matching result files for current fio config:")
@@ -1193,7 +1193,7 @@ class SPDKTarget(Target): 
            fh.write(str(proc.pid))

        self.nvmf_proc = proc

        self.log_print("SPDK NVMeOF Target PID=%s" % self.pid)

        self.log_print("Waiting for spdk to initilize...")

        self.log_print("Waiting for spdk to initialize...")

        while True:

            if os.path.exists("/var/tmp/spdk.sock"):

                break

scripts/perf/vhost/run_vhost_test.py

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ def gen_qemu_cpu_mask_config(spdk_cpu_list, vm_count, vm_cpu_num): 




def create_fio_cfg(template_dir, output_dir, **kwargs):

    fio_tempalte = os.path.join(template_dir, "fio_test.conf")

    fio_template = os.path.join(template_dir, "fio_test.conf")

    with open("scripts/perf/vhost/fio_test.conf", "r") as fh:

        cfg = fh.read()

    cfg = cfg.format(**kwargs)