Commit 1efa1b16 authored by Ankit Kumar's avatar Ankit Kumar Committed by Konrad Sztyber
Browse files

nvme: interface to check disconnected queue pairs 



The following commit will enable handling of interrupt events on nvme
poll group. For interrupt mode currently there is no way to check for
disconnected queue pairs at the transport level, whereas in poll mode
its done with every process completion call,

Change-Id: Ic87872d55f99e40a67c6e2e8861722b2cb256295
Signed-off-by: default avatarAnkit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25370


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
parent f43b7650

include/spdk/nvme.h

+3 −0
Original line number Diff line number Diff line
@@ -4623,6 +4623,9 @@ struct spdk_nvme_transport_ops { 
	int64_t (*poll_group_process_completions)(struct spdk_nvme_transport_poll_group *tgroup,

			uint32_t completions_per_qpair, spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb);



	void (*poll_group_check_disconnected_qpairs)(struct spdk_nvme_transport_poll_group *tgroup,

			spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb);



	int (*poll_group_destroy)(struct spdk_nvme_transport_poll_group *tgroup);



	int (*poll_group_get_stats)(struct spdk_nvme_transport_poll_group *tgroup,

lib/nvme/nvme_internal.h

+3 −0
Original line number Diff line number Diff line
@@ -1723,6 +1723,9 @@ int nvme_transport_poll_group_disconnect_qpair(struct spdk_nvme_qpair *qpair); 
int nvme_transport_poll_group_connect_qpair(struct spdk_nvme_qpair *qpair);

int64_t nvme_transport_poll_group_process_completions(struct spdk_nvme_transport_poll_group *tgroup,

		uint32_t completions_per_qpair, spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb);

void nvme_transport_poll_group_check_disconnected_qpairs(

	struct spdk_nvme_transport_poll_group *tgroup,

	spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb);

int nvme_transport_poll_group_destroy(struct spdk_nvme_transport_poll_group *tgroup);

int nvme_transport_poll_group_get_stats(struct spdk_nvme_transport_poll_group *tgroup,

					struct spdk_nvme_transport_poll_group_stat **stats);

lib/nvme/nvme_pcie.c

+1 −0
Original line number Diff line number Diff line
@@ -1154,6 +1154,7 @@ const struct spdk_nvme_transport_ops pcie_ops = { 
	.poll_group_add = nvme_pcie_poll_group_add,

	.poll_group_remove = nvme_pcie_poll_group_remove,

	.poll_group_process_completions = nvme_pcie_poll_group_process_completions,

	.poll_group_check_disconnected_qpairs = nvme_pcie_poll_group_check_disconnected_qpairs,

	.poll_group_destroy = nvme_pcie_poll_group_destroy,

	.poll_group_get_stats = nvme_pcie_poll_group_get_stats,

	.poll_group_free_stats = nvme_pcie_poll_group_free_stats

lib/nvme/nvme_pcie_common.c

+11 −0
Original line number Diff line number Diff line
@@ -1817,6 +1817,17 @@ nvme_pcie_poll_group_process_completions(struct spdk_nvme_transport_poll_group * 
	return total_completions;

}



void

nvme_pcie_poll_group_check_disconnected_qpairs(struct spdk_nvme_transport_poll_group *tgroup,

		spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb)

{

	struct spdk_nvme_qpair *qpair, *tmp_qpair;



	STAILQ_FOREACH_SAFE(qpair, &tgroup->disconnected_qpairs, poll_group_stailq, tmp_qpair) {

		disconnected_qpair_cb(qpair, tgroup->group->ctx);

	}

}



int

nvme_pcie_poll_group_destroy(struct spdk_nvme_transport_poll_group *tgroup)

{

lib/nvme/nvme_pcie_internal.h

+3 −0
Original line number Diff line number Diff line
@@ -348,6 +348,9 @@ int nvme_pcie_poll_group_remove(struct spdk_nvme_transport_poll_group *tgroup, 
int64_t nvme_pcie_poll_group_process_completions(struct spdk_nvme_transport_poll_group *tgroup,

		uint32_t completions_per_qpair,

		spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb);

void nvme_pcie_poll_group_check_disconnected_qpairs(

	struct spdk_nvme_transport_poll_group *tgroup,

	spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb);

int nvme_pcie_poll_group_destroy(struct spdk_nvme_transport_poll_group *tgroup);



#endif