Commit 1e879636 authored Oct 08, 2019 by Shuhei Matsumoto Committed by Changpeng Liu Oct 09, 2019

lib/iscsi: Handle IN_LOGIN as the same way as RUNNING for flushing PDUs



Previously When the connection is in login processing, flushing PDUs
had been done by tight loop. Login processing will not fill out
send buffers but we can use poller to flush PDUs as same as when the
connection is running iscsi_conn_flush_pdus().

Hence change the check condition to include INVALID state to use
poller in iscsi_conn_flush_pdus().

This change is necessary because the subsequent patches will change
iscsi_conn_flush_pdus() not to flush PDUs when the connection is not
invalid or running.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I543a912bf1aa957df7033184ce5989ac92367e49
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470702


Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent 26d6706b

lib/iscsi/conn.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1267,7 +1267,7 @@ iscsi_conn_flush_pdus(void *_conn)
		struct spdk_iscsi_conn *conn = _conn;
		int rc;

		if (conn->state == ISCSI_CONN_STATE_RUNNING) {
		if (conn->state <= ISCSI_CONN_STATE_RUNNING) {
		rc = iscsi_conn_flush_pdus_internal(conn);
		if (rc == 0 && conn->flush_poller != NULL) {
		spdk_poller_unregister(&conn->flush_poller);