Commit 1e1c1efa authored by Boris Glimcher's avatar Boris Glimcher Committed by Tomasz Zawadzki
Browse files

rpc: drop deprecated RPC command aliases 



Remove old RPC command aliases (e.g. *_engine, enable_vmd, construct_daos_bdev,
etc.) that were kept for backward compatibility. These aliases have been
deprecated for some time and are no longer needed.

Users must now call the canonical RPC commands directly:
- accel_get_module_info (was accel_get_engine_info)
- dsa_scan_accel_module (was dsa_scan_accel_engine)
- iaa_scan_accel_module (was iaa_scan_accel_engine)
- ioat_scan_accel_module (was ioat_scan_accel_engine)
- vmd_enable (was enable_vmd)
- bdev_daos_create / delete (were construct_daos_bdev / delete_daos_bdev)
- bdev_lvol_get_lvstores (was get_lvol_stores)

This cleans up duplicated registrations and simplifies CLI parser definitions.

Change-Id: I0823f020654c7125eed41b2df9f8a457933f0a9e
Signed-off-by: default avatarBoris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26807


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Community-CI: Mellanox Build Bot
parent dbc4eb64

lib/accel/accel_rpc.c

+0 −1
Original line number Diff line number Diff line
@@ -103,7 +103,6 @@ rpc_accel_get_module_info(struct spdk_jsonrpc_request *request, 
	spdk_jsonrpc_end_result(request, info.w);

}

SPDK_RPC_REGISTER("accel_get_module_info", rpc_accel_get_module_info, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(accel_get_module_info, accel_get_engine_info)



struct rpc_accel_assign_opc {

	char *opname;

module/accel/dsa/accel_dsa_rpc.c

+0 −1
Original line number Diff line number Diff line
@@ -53,4 +53,3 @@ rpc_dsa_scan_accel_module(struct spdk_jsonrpc_request *request, 
	spdk_jsonrpc_send_bool_response(request, true);

}

SPDK_RPC_REGISTER("dsa_scan_accel_module", rpc_dsa_scan_accel_module, SPDK_RPC_STARTUP)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(dsa_scan_accel_module, dsa_scan_accel_engine)

module/accel/iaa/accel_iaa_rpc.c

+0 −1
Original line number Diff line number Diff line
@@ -34,4 +34,3 @@ rpc_iaa_scan_accel_module(struct spdk_jsonrpc_request *request, 
	spdk_jsonrpc_send_bool_response(request, true);

}

SPDK_RPC_REGISTER("iaa_scan_accel_module", rpc_iaa_scan_accel_module, SPDK_RPC_STARTUP)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(iaa_scan_accel_module, iaa_scan_accel_engine)

module/accel/ioat/accel_ioat_rpc.c

+0 −1
Original line number Diff line number Diff line
@@ -25,4 +25,3 @@ rpc_ioat_scan_accel_module(struct spdk_jsonrpc_request *request, 
	spdk_jsonrpc_send_bool_response(request, true);

}

SPDK_RPC_REGISTER("ioat_scan_accel_module", rpc_ioat_scan_accel_module, SPDK_RPC_STARTUP)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(ioat_scan_accel_module, ioat_scan_accel_engine)

module/bdev/daos/bdev_daos_rpc.c

+0 −2
Original line number Diff line number Diff line
@@ -76,7 +76,6 @@ cleanup: 
	free_rpc_construct_daos(&req);

}

SPDK_RPC_REGISTER("bdev_daos_create", rpc_bdev_daos_create, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_daos_create, construct_daos_bdev)



struct rpc_delete_daos {

	char *name;
@@ -126,7 +125,6 @@ cleanup: 
}



SPDK_RPC_REGISTER("bdev_daos_delete", rpc_bdev_daos_delete, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_daos_delete, delete_daos_bdev)



struct rpc_bdev_daos_resize {

	char *name;