Commit 1d737a8d authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

test/iscsi: add target node config parsing test 



Change-Id: I39d74043e73aef9e51aca342308b0ec774a9c481
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent b4a15dfb

test/lib/iscsi/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ 
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../..)

include $(SPDK_ROOT_DIR)/mk/spdk.common.mk



DIRS-y = param

DIRS-y = param target_node



.PHONY: all clean $(DIRS-y)

test/lib/iscsi/iscsi.sh

+4 −0
Original line number Diff line number Diff line
@@ -12,4 +12,8 @@ timing_enter param 
$testdir/param/param_ut

timing_exit param



timing_enter target_node

$testdir/target_node/target_node_ut $testdir/target_node/target_node.conf

timing_exit target_node



timing_exit iscsi

test/lib/iscsi/target_node/.gitignore

0 → 100644
+1 −0
Original line number Diff line number Diff line 
target_node_ut

test/lib/iscsi/target_node/Makefile

0 → 100644
+59 −0
Original line number Diff line number Diff line 
#

#  BSD LICENSE

#

#  Copyright (c) Intel Corporation.

#  All rights reserved.

#

#  Redistribution and use in source and binary forms, with or without

#  modification, are permitted provided that the following conditions

#  are met:

#

#    * Redistributions of source code must retain the above copyright

#      notice, this list of conditions and the following disclaimer.

#    * Redistributions in binary form must reproduce the above copyright

#      notice, this list of conditions and the following disclaimer in

#      the documentation and/or other materials provided with the

#      distribution.

#    * Neither the name of Intel Corporation nor the names of its

#      contributors may be used to endorse or promote products derived

#      from this software without specific prior written permission.

#

#  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

#  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

#  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR

#  A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT

#  OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,

#  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

#  LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

#  DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

#  THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

#  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

#  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

#



SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../../..)

include $(SPDK_ROOT_DIR)/mk/spdk.common.mk



SPDK_LIBS += $(SPDK_ROOT_DIR)/lib/log/libspdk_log.a \

	     $(SPDK_ROOT_DIR)/lib/conf/libspdk_conf.a \

	     $(SPDK_ROOT_DIR)/lib/util/libspdk_util.a \

	     $(SPDK_ROOT_DIR)/lib/cunit/libspdk_cunit.a



CFLAGS += $(DPDK_INC)

CFLAGS += -I$(SPDK_ROOT_DIR)/test

CFLAGS += -I$(SPDK_ROOT_DIR)/lib

LIBS += $(SPDK_LIBS)

LIBS += -lcunit



APP = target_node_ut

C_SRCS = target_node_ut.c



all: $(APP)



$(APP): $(OBJS) $(SPDK_LIBS)

	$(LINK_C)



clean:

	$(CLEAN_C) $(APP)



include $(SPDK_ROOT_DIR)/mk/spdk.deps.mk

test/lib/iscsi/target_node/target_node.conf

0 → 100644
+95 −0
Original line number Diff line number Diff line 
[Global]



# Test that parsing fails if there is no TargetName

[Failure0]

  TargetAlias "Data Disk1"

  Mapping PortalGroup1 InitiatorGroup1

  AuthMethod Auto

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1



# Test that parsing fails if there is no Mapping

[Failure1]

  TargetName target1

  TargetAlias "Data Disk1"

  AuthMethod Auto

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1



# Test that parsing fails if Mapping does not define Portal or InitiatorGroup

[Failure2]

  TargetName target1

  TargetAlias "Data Disk1"

  Mapping

  AuthMethod Auto

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1



# Test that parsing fails if Mapping does not define InitiatorGroup

[Failure3]

  TargetName target1

  TargetAlias "Data Disk1"

  Mapping PortalGroup1

  AuthMethod Auto

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1



# Test that parsing fails if Mapping switches PortalGroup/InitiatorGroup order

[Failure4]

  TargetName target1

  TargetAlias "Data Disk1"

  Mapping InitiatorGroup1 PortalGroup1

  AuthMethod Auto

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1



# Test that parsing fails if Mapping uses invalid InitiatorGroup0

[Failure5]

  TargetName target1

  TargetAlias "Data Disk1"

  Mapping PortalGroup1 InitiatorGroup0

  AuthMethod Auto

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1



# Test that parsing fails if Mapping uses invalid PortalGroup0

[Failure6]

  TargetName target1

  TargetAlias "Data Disk1"

  Mapping PortalGroup0 InitiatorGroup1

  AuthMethod Auto

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1



# Test that parsing fails if AuthMethod is invalid

[Failure7]

  TargetName target1

  TargetAlias "Data Disk1"

  Mapping PortalGroup1 InitiatorGroup1

  AuthMethod SomeGarbage

  AuthGroup AuthGroup1

  UseDigest Auto

  QueueDepth 128

  LUN0 Malloc0

  LUN1 Malloc1