Commit 1d1496dc authored by Liang Yan's avatar Liang Yan Committed by Jim Harris
Browse files

trace: update TpointGroupMask comment and related code 



Update spdk target config files and codes to only enable
16 trace group at most.

Change-Id: I1bd26ccea05d73cea54cbbcf2fcefa869d621352
Signed-off-by: default avatarLiang Yan <liang.z.yan@intel.com>
Reviewed-on: https://review.gerrithub.io/422478


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 242201d2

etc/spdk/iscsi.conf.in

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 


  # Tracepoint group mask for spdk trace buffers

  # Default: 0x0 (all tracepoint groups disabled)

  # Set to 0xFFFFFFFFFFFFFFFF to enable all tracepoint groups.

  # Set to 0xFFFF to enable all tracepoint groups.

  #TpointGroupMask 0x0



# Users may activate entries in this section to override default values for

etc/spdk/nvmf.conf.in

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ 


  # Tracepoint group mask for spdk trace buffers

  # Default: 0x0 (all tracepoint groups disabled)

  # Set to 0xFFFFFFFFFFFFFFFF to enable all tracepoint groups.

  # Set to 0xFFFF to enable all tracepoint groups.

  #TpointGroupMask 0x0



  # PciBlacklist and PciWhitelist cannot be used at the same time

etc/spdk/vhost.conf.in

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 


  # Tracepoint group mask for spdk trace buffers

  # Default: 0x0 (all tracepoint groups disabled)

  # Set to 0xFFFFFFFFFFFFFFFF to enable all tracepoint groups.

  # Set to 0xFFFF to enable all tracepoint groups.

  #TpointGroupMask 0x0



# Users may activate entries in this section to override default values for

lib/event/app.c

+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static char g_cmdline_short_opts[2 * SPDK_APP_MAX_CMDLINE_OPTIONS + 1]; 
"\n" \

"  # Tracepoint group mask for spdk trace buffers\n" \

"  # Default: 0x0 (all tracepoint groups disabled)\n" \

"  # Set to 0xFFFFFFFFFFFFFFFF to enable all tracepoint groups.\n" \

"  # Set to 0xFFFF to enable all tracepoint groups.\n" \

"  TpointGroupMask \"0x%" PRIX64 "\"\n" \

"\n" \

lib/trace/trace_flags.c

+1 −1
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ spdk_trace_set_tpoint_group_mask(uint64_t tpoint_group_mask) 
{

	int i;



	for (i = 0; i < 64; i++) {

	for (i = 0; i < SPDK_TRACE_MAX_GROUP_ID; i++) {

		if (tpoint_group_mask & (1ULL << i)) {

			spdk_trace_set_tpoints(i, -1ULL);

		}