Commit 1d08c962 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

lib/iscsi: Remove unused the param iaddr from iscsi_send_tgts() 



Previously we might have any possibility to need iaddr in
iscsi_send_tgts(), but it is highly unlikely now. Let's remove
the param iaddr from iscsi_send_tgts().

Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ide3405706b727a9d6ebaa92ed83509196ff675da
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3442


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent c15a6180

lib/iscsi/iscsi.c

+0 −2
Original line number Diff line number Diff line
@@ -2377,7 +2377,6 @@ iscsi_pdu_payload_op_text(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *p 


			data_len = iscsi_send_tgts(conn,

						   conn->initiator_name,

						   conn->initiator_addr,

						   val, data, alloc_len,

						   data_len);

		} else {
@@ -2392,7 +2391,6 @@ iscsi_pdu_payload_op_text(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *p 
			} else {

				data_len = iscsi_send_tgts(conn,

							   conn->initiator_name,

							   conn->initiator_addr,

							   val, data, alloc_len,

							   data_len);

			}

lib/iscsi/tgt_node.c

+1 −2
Original line number Diff line number Diff line
@@ -298,8 +298,7 @@ iscsi_tgt_node_allow_iscsi_name(struct spdk_iscsi_tgt_node *target, const char * 


int

iscsi_send_tgts(struct spdk_iscsi_conn *conn, const char *iiqn,

		const char *iaddr, const char *tiqn, uint8_t *data, int alloc_len,

		int data_len)

		const char *tiqn, uint8_t *data, int alloc_len, int data_len)

{

	char buf[MAX_TMPBUF];

	struct spdk_iscsi_portal_grp	*pg;

lib/iscsi/tgt_node.h

+1 −2
Original line number Diff line number Diff line
@@ -102,8 +102,7 @@ void iscsi_shutdown_tgt_node_by_name(const char *target_name, 
				     iscsi_tgt_node_destruct_cb cb_fn, void *cb_arg);

bool iscsi_tgt_node_is_destructed(struct spdk_iscsi_tgt_node *target);

int iscsi_send_tgts(struct spdk_iscsi_conn *conn, const char *iiqn,

		    const char *iaddr, const char *tiqn, uint8_t *data, int alloc_len,

		    int data_len);

		    const char *tiqn, uint8_t *data, int alloc_len, int data_len);



/*

 * bdev_name_list and lun_id_list are equal sized arrays of size num_luns.

test/unit/lib/iscsi/iscsi.c/iscsi_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ iscsi_tgt_node_access(struct spdk_iscsi_conn *conn, 
}



DEFINE_STUB(iscsi_send_tgts, int,

	    (struct spdk_iscsi_conn *conn, const char *iiqn, const char *iaddr,

	    (struct spdk_iscsi_conn *conn, const char *iiqn,

	     const char *tiqn, uint8_t *data, int alloc_len, int data_len),

	    0);