Commit 1cb73242 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

bdev_fio: remove legacy config support 



This patch removes legacy config from bdev fio_plugin.

Both configuration options are valid, but they should
point to JSON files.

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Change-Id: I5ae8102752317fe6da8ae7d0a69f444cb0751efa
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3721


Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent c72a1643

CHANGELOG.md

+5 −0
Original line number Diff line number Diff line
@@ -34,6 +34,11 @@ and removed `usr1_handler` from `struct spdk_app_opts` callback that was used to 


Updated DPDK submodule to DPDK 20.08.



### fio



Bdev fio_plugin no longer supports legacy configuration files. Options `spdk_conf` and

`spdk_json_conf` have to point to valid JSON configuration.



### gpt



Removed option to disable GPT probing via legacy configuration. Please use generic

examples/bdev/fio_plugin/README.md

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ directory as this README). 


The fio configuration file must contain one new parameter:



    spdk_conf=./examples/bdev/fio_plugin/bdev.conf

    spdk_json_conf=./examples/bdev/fio_plugin/bdev.json



This must point at an SPDK configuration file. There are a number of example configuration

files in the SPDK repository under etc/spdk.

examples/bdev/fio_plugin/bdev.conf.in

deleted100644 → 0
+0 −3
Original line number Diff line number Diff line 
[Malloc]

  NumberOfLuns 1

  LunSizeInMB 128

examples/bdev/fio_plugin/bdev.json

0 → 100644
+17 −0
Original line number Diff line number Diff line 
{

  "subsystems": [

    {

      "subsystem": "bdev",

      "config": [

        {

          "params": {

            "block_size": 512,

            "num_blocks": 262144,

            "name": "Malloc0"

          },

          "method": "bdev_malloc_create"

        }

      ]

    }

  ]

}

examples/bdev/fio_plugin/example_config.fio

+2 −1
Original line number Diff line number Diff line 
[global]

ioengine=spdk_bdev

spdk_conf=./examples/bdev/fio_plugin/bdev.conf.in

spdk_json_conf=./examples/bdev/fio_plugin/bdev.json

thread=1

group_reporting=1

direct=1
@@ -13,4 +13,5 @@ rw=randrw 
bs=4k



[test]

filename=Malloc0

numjobs=1