Commit 1c54ba1c authored by Pawel Wodkowski's avatar Pawel Wodkowski Committed by Darek Stojaczyk
Browse files

vhost_nvme/rpc: free partially decoded request 



Partially decoded request need to be free even if
spdk_json_decode_object() fails.

Change-Id: Icd00f835537dbaf197cc4f05930be8c543a534a6
Signed-off-by: default avatarPawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/439716


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
parent 26979c50

lib/vhost/vhost_rpc.c

+2 −2
Original line number Diff line number Diff line
@@ -686,7 +686,7 @@ static void 
spdk_rpc_construct_vhost_nvme_controller(struct spdk_jsonrpc_request *request,

		const struct spdk_json_val *params)

{

	struct rpc_vhost_nvme_ctrlr req = {0};

	struct rpc_vhost_nvme_ctrlr req = {};

	struct spdk_json_write_ctx *w;

	int rc;
@@ -699,7 +699,6 @@ spdk_rpc_construct_vhost_nvme_controller(struct spdk_jsonrpc_request *request, 


	rc = spdk_vhost_nvme_dev_construct(req.ctrlr, req.cpumask, req.io_queues);

	if (rc < 0) {

		free_rpc_vhost_nvme_ctrlr(&req);

		goto invalid;

	}
@@ -715,6 +714,7 @@ spdk_rpc_construct_vhost_nvme_controller(struct spdk_jsonrpc_request *request, 
	return;



invalid:

	free_rpc_vhost_nvme_ctrlr(&req);

	spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,

					 spdk_strerror(-rc));